-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rely on docker-image-cleaner in external repo #1391
Rely on docker-image-cleaner in external repo #1391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great, but I want to give others who aren't already involved in this decision a chance to weigh in before I hit merge. I'll wait a week maybe?
/cc @sgibson91 @betatim @manics @minrk :)
I haven't tested it, but assuming it works I can't think of any reason not to do this 😄 |
Fine for me. As always my main thoughts are around "what could break if we do this?" and "is this backwards compatible?" |
Given this broad approval, I'll go for a merge, and later today try go for a mybinder.org deploy and steward this change all the way there. |
jupyterhub/binderhub#1391 Merge pull request #1391 from consideRatio/pr/use-external-image-cleaner
This PR is successfully deployed all the way to mybinder.org-deploy. It had to be complemented with #1417. |
@yuvipanda and I worked to migrate the image-cleaner code and docker image from this repo to its own project in jupyterhub/docker-image-cleaner. It helps reduce the complexity of this repo that includes a lot of parts that could be split into smaller more comprehensible pieces.
With this PR, I remove the code the image cleaner code that now lives in the jupyterhub/docker-image-cleaner git repo.