Rely on docker-image-cleaner in external repo #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
reviewed
Sep 24, 2021
|
Nice :D |
yuvipanda
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
I think this is great, but I want to give others who aren't already involved in this decision a chance to weigh in before I hit merge. I'll wait a week maybe?
/cc @sgibson91 @betatim @manics @minrk :)
|
I haven't tested it, but assuming it works I can't think of any reason not to do this 😄 |
|
Fine for me. As always my main thoughts are around "what could break if we do this?" and "is this backwards compatible?" |
minrk
approved these changes
Oct 1, 2021
betatim
approved these changes
Oct 1, 2021
sgibson91
approved these changes
Oct 7, 2021
|
Given this broad approval, I'll go for a merge, and later today try go for a mybinder.org deploy and steward this change all the way there. |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 7, 2021
jupyterhub/binderhub#1391 Merge pull request #1391 from consideRatio/pr/use-external-image-cleaner
This was referenced Oct 7, 2021
|
This PR is successfully deployed all the way to mybinder.org-deploy. It had to be complemented with #1417. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yuvipanda and I worked to migrate the image-cleaner code and docker image from this repo to its own project in jupyterhub/docker-image-cleaner. It helps reduce the complexity of this repo that includes a lot of parts that could be split into smaller more comprehensible pieces.
With this PR, I remove the code the image cleaner code that now lives in the jupyterhub/docker-image-cleaner git repo.