Make the package compatible with zeep 4.2.1 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
iloveitaly
reviewed
Oct 17, 2023
| @@ -97,13 +97,9 @@ def _generate_wsdl_url(self) -> str: | |||
| def _generate_cache(self) -> zeep.cache.Base: | |||
| return zeep.cache.SqliteCache(timeout=60 * 60 * 24 * 365) | |||
|
|
|||
| def _generate_session(self) -> zeep.requests.Session: | |||
| return zeep.requests.Session() | |||
|
|
|||
There was a problem hiding this comment.
what do we lose removing this?
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 35.10% 35.83% +0.73%
==========================================
Files 26 26
Lines 1054 1052 -2
==========================================
+ Hits 370 377 +7
+ Misses 684 675 -9
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #46
By simply not adding the session argument which according to mvantellingen/python-zeep@2f35b7d
was not used anyway.