Make the package compatible with zeep 4.2.1 (#48)

* Make the package compatible with zeep 4.2.1 * Accept 4.2.1 or higher --------- Co-authored-by: Michael Bianco <[email protected]>
jacobsvante · Oct 19, 2023 · 846d668 · 846d668
1 parent 6fbe948
commit 846d668
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/netsuite/soap_api/client.py b/netsuite/soap_api/client.py
@@ -97,13 +97,9 @@ def _generate_wsdl_url(self) -> str:
     def _generate_cache(self) -> zeep.cache.Base:
         return zeep.cache.SqliteCache(timeout=60 * 60 * 24 * 365)
 
-    def _generate_session(self) -> zeep.requests.Session:
-        return zeep.requests.Session()
-
     def _generate_transport(self) -> zeep.transports.AsyncTransport:
         return AsyncNetSuiteTransport(
             self.wsdl_url,
-            session=self._generate_session(),
             cache=self.cache,
         )
 

diff --git a/tests/test_soap_api.py b/tests/test_soap_api.py
@@ -17,3 +17,7 @@ def test_netsuite_wsdl_url(dummy_config):
         soap_api.wsdl_url
         == "https://123456-sb1.suitetalk.api.netsuite.com/wsdl/v2021_1_0/netsuite.wsdl"
     )
+
+def test_netsuite_transport_initialization(dummy_config):
+    soap_api = NetSuiteSoapApi(dummy_config)
+    soap_api._generate_transport()