Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeep 4.2.0 issues #46

Closed
andwaredev opened this issue Nov 4, 2022 · 4 comments · Fixed by #48
Closed

Zeep 4.2.0 issues #46

andwaredev opened this issue Nov 4, 2022 · 4 comments · Fixed by #48

Comments

@andwaredev
Copy link

We are seeing a TypeError: TypeError: __init__() got an unexpected keyword argument 'session' since the latest version 4.2.0 of zeep released yesterday, 11/3/2022.

After a bit of sleuthing, it appears that pyproject.toml only pins zeep to major version 4.

As we haven't explicitly pinned zeep in our project, we began to encounter issues when 4.2.0 was pulled in.

Our fix was to pin zeep==4.1.0, which resolves the issue which can be found in the stack trace below:

File \"/var/task/netsuite/soap_api/client.py\", line 168, in Core\n    return self._type_factory(\"core\", \"platform\")\n  File \"/var/task/netsuite/soap_api/client.py\", line 152, in _type_factory\n    return self.client.type_factory(self._get_namespace(name, sub_namespace))\n  File \"/var/lang/lib/python3.8/functools.py\", line 967, in __get__\n    val = self.func(instance)\n  File \"/var/task/netsuite/soap_api/client.py\", line 84, in client\n    return self._generate_client()\n  File \"/var/task/netsuite/soap_api/client.py\", line 141, in _generate_client\n    transport=self.transport,\n  File \"/var/lang/lib/python3.8/functools.py\", line 967, in __get__\n    val = self.func(instance)\n  File \"/var/task/netsuite/soap_api/client.py\", line 88, in transport\n    return self._generate_transport()\n  File \"/var/task/netsuite/soap_api/client.py\", line 119, in _generate_transport\n    return AsyncNetSuiteTransport(\n  File \"/var/task/netsuite/soap_api/transports.py\", line 26, in __init__\n    super().__init__(*args, **kwargs)\nTypeError: __init__() got an unexpected keyword argument 'session'\n"
@jacobsvante
Copy link
Owner

This sounds like a breaking change on their part. I would suggest opening up a PR in zeep's issue tracker.

@YuriOsipov
Copy link

Seems session field is messing in class AsyncTransport(Transport):
Should be
def init(
self,
client=None,
wsdl_client=None,
cache=None,
timeout=300,
operation_timeout=None,
verify_ssl=True,
proxy=None,
session=None
):

@TouwaStar
Copy link
Contributor

@jacobsvante

This sounds like a breaking change on their part. I would suggest opening up a PR in zeep's issue tracker.

This isnt really their problem, this package has zeep as a dependency so would be nice to either pin it to the working version or adjust to the new one

@TouwaStar
Copy link
Contributor

#48 Can someone take a look at this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants