WIP : PHP8

[iruzevic]

⚠️ PHP8 preparation branch

Description

• updating composer packages
• fixing stan and lint issues
• updating composer command names
• Denis fixes for standards
• adding missing type hinting
• Config changed definition of version and name
• Blocks removing "old" version functions
• new command to change version number
• fixed broken db import command with the wrong setup.json path
• adding better copy for checkAttr helper if key is missing.
• Every enqueue script now has is<>Used method that is by default true.

Note

To install and test the latest version, use this command:

npx create-wp-project@latest --eightshiftLibsBranch="develop-php8" --eightshiftFrontendLibsBranch="develop-php8" --eightshiftBoilerplateBranch='develop-php8'

Connected PRs

infinum/eightshift-boilerplate#273
infinum/eightshift-frontend-libs#761
#381

[dingo-d]

Left some minor comments.

The thing I'm more worried about is the change in the component rendering.
Several tests are failing (some of which are easy to fix), but for some, I'm not sure the behavior is correct, or at least this new feature has kinda complicated testing.

Because inside the tests you don't have WordPress, the test for the feature could be actually correct, but this new exception would make it seem like it's not correct.

For instance, the following test:

test('Asserts that rendering a component works', function () {
	$results = Components::render('button', []);

	expect($results)
		->not->toBeEmpty()
		->toContain('Hello!');
});

This should be correct (confirming that rendering actually works), but this will now throw an exception: You are not allowed to access paths outside of themes or plugins folder!

So I think that either this should be fixed in test setup, to somehow 'trick' the code to think that during tests we are inside WordPress theme/plugin, or at the code level with a flag 🤷🏼‍♂️

[iruzevic]

Left some minor comments.

The thing I'm more worried about is the change in the component rendering. Several tests are failing (some of which are easy to fix), but for some, I'm not sure the behavior is correct, or at least this new feature has kinda complicated testing.

Because inside the tests you don't have WordPress, the test for the feature could be actually correct, but this new exception would make it seem like it's not correct.

For instance, the following test:

test('Asserts that rendering a component works', function () {
	$results = Components::render('button', []);

	expect($results)
		->not->toBeEmpty()
		->toContain('Hello!');
});

This should be correct (confirming that rendering actually works), but this will now throw an exception: You are not allowed to access paths outside of themes or plugins folder!

So I think that either this should be fixed in test setup, to somehow 'trick' the code to think that during tests we are inside WordPress theme/plugin, or at the code level with a flag 🤷🏼‍♂️

I have fixed all the tests

[codecov]

Codecov Report

Merging #381 (5f976a7) into develop (cddf63a) will decrease coverage by 2.82%.
Report is 32 commits behind head on develop.
The diff coverage is 49.43%.

@@              Coverage Diff              @@
##             develop     #381      +/-   ##
=============================================
- Coverage      84.41%   81.60%   -2.82%     
- Complexity      1273     1357      +84     
=============================================
  Files            135      138       +3     
  Lines           6088     6359     +271     
=============================================
+ Hits            5139     5189      +50     
- Misses           949     1170     +221     

Flag	Coverage Δ
unittests	81.60% <49.43%> (-2.82%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/AdminMenus/AdminReusableBlocksMenuCli.php	100.00% <100.00%> (ø)
src/AnalyticsGdpr/AnalyticsGdprExample.php	99.83% <ø> (ø)
src/Blocks/AbstractBlocks.php	97.04% <ø> (-0.33%)	⬇️
src/Blocks/BlocksExample.php	100.00% <100.00%> (+9.09%)	⬆️
src/Blocks/UseAssetsCli.php	100.00% <100.00%> (ø)
src/Blocks/UseBlockCli.php	100.00% <100.00%> (ø)
src/Blocks/UseComponentCli.php	100.00% <100.00%> (ø)
src/Blocks/UseGlobalAssetsCli.php	100.00% <100.00%> (ø)
src/Blocks/UseManifestCli.php	100.00% <100.00%> (ø)
src/Blocks/UseVariationCli.php	100.00% <100.00%> (ø)
... and 34 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[iruzevic]

I can't any errors in the tests, linters or stan. Also There are no issues in the debug log. Npx is working as expected :D I thing this setup is ready for PHP8.2. WooCommerce is also working :D