Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP : PHP8 #761

Merged
merged 8 commits into from
Nov 6, 2023
Merged

WIP : PHP8 #761

merged 8 commits into from
Nov 6, 2023

Conversation

iruzevic
Copy link
Member

@iruzevic iruzevic commented Oct 26, 2023 •
edited
Loading

⚠️ PHP8 preparation branch

Description

  • updating composer packages
  • removing unnecessary standards and ignoring lines.
  • updating composer command names
  • updating npx command readme
  • adding better copy for checkAttr helper if key is missing

Note

To install and test the latest version, use this command:

npx create-wp-project@latest --eightshiftLibsBranch="develop-php8" --eightshiftFrontendLibsBranch="develop-php8" --eightshiftBoilerplateBranch='develop-php8'

Connected PRs

infinum/eightshift-boilerplate#273
#761
infinum/eightshift-libs#381

@iruzevic iruzevic requested a review from a team October 26, 2023 07:49
@iruzevic iruzevic self-assigned this Oct 26, 2023
@iruzevic iruzevic marked this pull request as draft October 26, 2023 07:49
vedranpetrac
vedranpetrac previously approved these changes Oct 26, 2023
View reviewed changes
iobrado
iobrado previously approved these changes Oct 26, 2023
View reviewed changes
@iruzevic iruzevic dismissed stale reviews from iobrado and vedranpetrac via 7edd1ac October 26, 2023 07:57
This was referenced Oct 26, 2023
Merged
Merged
@iruzevic iruzevic requested review from a team, iobrado and vedranpetrac October 27, 2023 13:12
iobrado
iobrado previously approved these changes Oct 27, 2023
View reviewed changes
kancijan
kancijan previously approved these changes Oct 27, 2023
View reviewed changes
@iruzevic iruzevic dismissed stale reviews from kancijan and iobrado via 631c3f9 October 27, 2023 21:37
goranalkovic-infinum
goranalkovic-infinum requested changes Oct 30, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
iobrado
iobrado previously approved these changes Oct 30, 2023
View reviewed changes
dadadavorin
dadadavorin previously approved these changes Oct 30, 2023
View reviewed changes
piqusy
piqusy previously approved these changes Oct 30, 2023
View reviewed changes
scripts/editor/attributes.js Show resolved Hide resolved
vedranpetrac
vedranpetrac previously approved these changes Oct 30, 2023
View reviewed changes
kancijan
kancijan previously approved these changes Oct 30, 2023
View reviewed changes
@iruzevic @goranalkovic-infinum
Update composer.json
77e8f7f 
Co-authored-by: Goran Alković <[email protected]>
@iruzevic iruzevic marked this pull request as ready for review October 31, 2023 07:11
@iruzevic iruzevic merged commit 023f88b into develop Nov 6, 2023
3 of 6 checks passed
@iruzevic iruzevic deleted the develop-php8 branch November 6, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dingo-d dingo-d dingo-d approved these changes

@kancijan kancijan kancijan left review comments

@vedranpetrac vedranpetrac vedranpetrac left review comments

@dadadavorin dadadavorin dadadavorin left review comments

@goranalkovic-infinum goranalkovic-infinum goranalkovic-infinum left review comments

@iobrado iobrado iobrado left review comments

@piqusy piqusy piqusy left review comments

Assignees

@iruzevic iruzevic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@iruzevic @dingo-d @piqusy @iobrado @goranalkovic-infinum @dadadavorin @vedranpetrac @kancijan