Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : PHP8 #273

Merged
merged 6 commits into from
Nov 6, 2023
Merged

WIP : PHP8 #273

merged 6 commits into from
Nov 6, 2023

Conversation

iruzevic
Copy link
Member

@iruzevic iruzevic commented Oct 26, 2023

Description

  • updating composer packages

Note

To install and test the latest version, use this command:

npx create-wp-project@latest --eightshiftLibsBranch="develop-php8" --eightshiftFrontendLibsBranch="develop-php8" --eightshiftBoilerplateBranch='develop-php8'

Connected PRs

#273
infinum/eightshift-frontend-libs#761
infinum/eightshift-libs#381

@iruzevic iruzevic requested a review from a team October 26, 2023 06:53
@iruzevic iruzevic self-assigned this Oct 26, 2023
@iruzevic iruzevic marked this pull request as draft October 26, 2023 06:53
piqusy
piqusy previously approved these changes Oct 26, 2023
@dingo-d
Copy link
Contributor

dingo-d commented Oct 26, 2023

The npx create command worked nicely on PHP 8.1.23 and node v20.9.0, but the header and footer menu seems to be missing an icon

image

The only warning I got was when I entered the customizer screen

[26-Oct-2023 09:58:44 UTC] PHP Warning:  Attempt to read property "title" on null in /Users/deniszoljom/Sites/wp-testing/wp-includes/class-wp-customize-widgets.php on line 905
[26-Oct-2023 09:58:44 UTC] PHP Stack trace:
[26-Oct-2023 09:58:44 UTC] PHP   1. {main}() /Users/deniszoljom/.composer/vendor/laravel/valet/server.php:0
[26-Oct-2023 09:58:44 UTC] PHP   2. require() /Users/deniszoljom/.composer/vendor/laravel/valet/server.php:250
[26-Oct-2023 09:58:44 UTC] PHP   3. do_action($hook_name = 'customize_controls_print_footer_scripts') /Users/deniszoljom/Sites/wp-testing/wp-admin/customize.php:302
[26-Oct-2023 09:58:44 UTC] PHP   4. WP_Hook->do_action($args = [0 => '']) /Users/deniszoljom/Sites/wp-testing/wp-includes/plugin.php:517
[26-Oct-2023 09:58:44 UTC] PHP   5. WP_Hook->apply_filters($value = '', $args = [0 => '']) /Users/deniszoljom/Sites/wp-testing/wp-includes/class-wp-hook.php:334
[26-Oct-2023 09:58:44 UTC] PHP   6. WP_Customize_Widgets->output_widget_control_templates('') /Users/deniszoljom/Sites/wp-testing/wp-includes/class-wp-hook.php:310

but nobody uses customizer so that's fine.

I'll need to do a deep dive to check if everything works as intended, but so far so good 👍🏼

@iruzevic iruzevic requested review from piqusy and a team October 27, 2023 13:11
iobrado
iobrado previously approved these changes Oct 27, 2023
iobrado
iobrado previously approved these changes Oct 30, 2023
composer.json Outdated Show resolved Hide resolved
Co-authored-by: Goran Alković <[email protected]>
@iruzevic iruzevic dismissed stale reviews from goranalkovic-infinum and iobrado via 5a48fdc October 31, 2023 07:10
@iruzevic iruzevic marked this pull request as ready for review October 31, 2023 07:10
@iruzevic iruzevic merged commit 0ad5fae into develop Nov 6, 2023
@iruzevic iruzevic deleted the develop-php8 branch November 6, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants