Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applied package.xml template #101

Open
wants to merge 5 commits into
base: humble
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,8 @@ repos:
- id: doc8
args: [--max-line-length=100, --ignore=D001]
exclude: ^.*\/CHANGELOG\.rst/.*$

- repo: https://github.com/comkieffer/pre-commit-xmllint.git
rev: 1.0.0
hooks:
- id: xmllint
Comment on lines +75 to +78
Copy link
Contributor

@rafal-gorecki rafal-gorecki Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO doesn't work without shema arg. To test it you can try modyfy package.xml and pre-commit run -a.
But adding schema makes issue with microros.xml. I to fix this, but I cannot find info how to ignore single file.

2 changes: 2 additions & 0 deletions rosbot/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
<name>rosbot</name>
<version>0.13.1</version>
<description>Meta package that contains all packages of Rosbot 2 2R PRO</description>

<maintainer email="[email protected]">Husarion</maintainer>

<license>Apache License 2.0</license>

<url type="website">https://husarion.com/</url>
Expand Down
2 changes: 1 addition & 1 deletion rosbot_bringup/config/microros_localhost_only.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<!--The only purpose of this file is to disable
Fast-DDS SHM transport used by default to use UDPv4-->
<dds>
<profiles xmlns="http://www.eprosima.com/XMLSchemas/fastRTPS_Profiles">
<profiles xmlns="https://raw.githubusercontent.com/eProsima/Fast-DDS/master/resources/xsd/fastRTPS_profiles.xsd">
<transport_descriptors>
<transport_descriptor>
<transport_id>CustomUdpTransport</transport_id>
Expand Down
2 changes: 2 additions & 0 deletions rosbot_bringup/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
<name>rosbot_bringup</name>
<version>0.13.1</version>
<description>ROSbot 2, 2R, PRO bringup package</description>

<maintainer email="[email protected]">Husarion</maintainer>

<license>Apache License 2.0</license>

<url type="website">https://husarion.com/</url>
Expand Down
2 changes: 2 additions & 0 deletions rosbot_controller/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
<name>rosbot_controller</name>
<version>0.13.1</version>
<description>Hardware configuration for ROSbot 2, 2R, PRO</description>

<maintainer email="[email protected]">Husarion</maintainer>

<license>Apache License 2.0</license>

<url type="website">https://husarion.com/</url>
Expand Down
4 changes: 3 additions & 1 deletion rosbot_description/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,17 @@
<name>rosbot_description</name>
<version>0.13.1</version>
<description>ROSbot 2, 2R, PRO description package</description>

<maintainer email="[email protected]">Husarion</maintainer>

<license>Apache License 2.0</license>

<url type="website">https://husarion.com/</url>
<url type="repository">https://github.com/husarion/rosbot_ros</url>
<url type="bugtracker">https://github.com/husarion/rosbot_ros/issues</url>

<author email="[email protected]">Jakub Delicat</author>
<author email="[email protected]">Maciej Stepien</author>
<author email="[email protected]">Jakub Delicat</author>

<buildtool_depend>ament_cmake</buildtool_depend>

Expand Down
4 changes: 3 additions & 1 deletion rosbot_gazebo/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,18 @@
<name>rosbot_gazebo</name>
<version>0.13.1</version>
<description>Gazebo Ignition simulation for ROSbot 2, 2R, PRO</description>

<maintainer email="[email protected]">Husarion</maintainer>

<license>Apache License 2.0</license>

<url type="website">https://husarion.com/</url>
<url type="repository">https://github.com/husarion/rosbot_ros</url>
<url type="bugtracker">https://github.com/husarion/rosbot_ros/issues</url>

<author email="[email protected]">Krzysztof Wojciechowski</author>
<author email="[email protected]">Jakub Delicat</author>
<author email="[email protected]">Rafal Gorecki</author>
<author email="[email protected]">Krzysztof Wojciechowski</author>

<exec_depend>rosbot_bringup</exec_depend>

Expand Down
2 changes: 2 additions & 0 deletions rosbot_utils/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
<name>rosbot_utils</name>
<version>0.13.1</version>
<description>Utilities for ROSbot 2R and 2 PRO</description>

<maintainer email="[email protected]">Husarion</maintainer>

<license>Apache License 2.0</license>

<url type="website">https://husarion.com/</url>
Expand Down
Loading