Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Update form field implementation and create rest of form components #416

Open
6 of 17 tasks
xelaint opened this issue Aug 30, 2019 · 3 comments · May be fixed by #3381, #3382 or #3383
Open
6 of 17 tasks

[FEAT] Update form field implementation and create rest of form components #416

xelaint opened this issue Aug 30, 2019 · 3 comments · May be fixed by #3381, #3382 or #3383
Assignees
Labels
feat a new feature, enhancement, or improvement p1 critical priority package: design @daffodil/design
Milestone

Comments

@xelaint
Copy link
Member

xelaint commented Aug 30, 2019

💡 Feature request

Feature Name

Update form field implementation and create rest of form components.

The Desired Behavior

https://www.figma.com/design/4A0SIso9uJ7HGKdW9GKMGr/Daffodil-Design-System?node-id=664-12082

  • Form field should support native select, custom select, native input, custom input, textarea, quantity field, and quantity select.
  • Input types to support:
<input type="date">
<input type="datetime-local">
<input type="email">
<input type="month">
<input type="number">
<input type="password">
<input type="search">
<input type="tel">
<input type="text">
<input type="time">
<input type="url">
<input type="week">
  • Manage disabled, focus, mutating, error, hints, and skeleton (loading) states.

The template API of daff-form-field should look something like:

<form>
  <daff-form-field>
    <label for="grace">Name</label>
    <input type="text" id="grace" placeholder="Test"/>
    <div class="error">Error message goes here.</div>
  </daff-form-field>

  <daff-form-field>
    <label for="grace">Name</label>
    <select>
   	<option></option>
    </select>
    <div class="select-arrow">:down_arrow:</div>
    <div class="error">Error message goes here.</div>
  </daff-form-field>

  <daff-form-field>
    <label for="grace">Name</label>
    <textarea id="grace"></textarea>
    <div class="select-arrow">:down_arrow:</div>
    <div class="error">Error message goes here.</div>
  </daff-form-field>

  <button type="submit">Submit</button>
</form>

Things to do:

Your Use Case

As a user, I should be able to fill out fields in a form.

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@xelaint xelaint added feat a new feature, enhancement, or improvement package: design @daffodil/design labels Aug 30, 2019
@xelaint xelaint self-assigned this Aug 30, 2019
@xelaint xelaint changed the title [FEAT] Update Form Field Implementation [FEAT] Update Form Field Implementation and create rest of form components Sep 3, 2019
@xelaint xelaint changed the title [FEAT] Update Form Field Implementation and create rest of form components [FEAT] Update form field Implementation and create rest of form components Sep 3, 2019
@xelaint xelaint changed the title [FEAT] Update form field Implementation and create rest of form components [FEAT] Update form field implementation and create rest of form components Sep 3, 2019
@xelaint xelaint assigned damienwebdev and xelaint and unassigned xelaint Feb 26, 2021
@xelaint xelaint pinned this issue Aug 18, 2021
@shadow0500
Copy link

Can I work on this ?

@damienwebdev
Copy link
Member

I think this is likely an internal ticket that either @xelaint or I need to work on, but thanks @shadow0500

@shadow0500
Copy link

Okay , No problem . Thank you for the feedback and for your response too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment