Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add textarea component #1562

Closed
wants to merge 1 commit into from
Closed

Conversation

lderrickable
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Addresses part of #416

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@lderrickable lderrickable added the package: design @daffodil/design label May 24, 2021
@lderrickable lderrickable self-assigned this May 24, 2021
@lderrickable lderrickable requested a review from a team as a code owner May 24, 2021 21:44
@damienwebdev damienwebdev self-assigned this Jul 28, 2021
Copy link
Member

@griest024 griest024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design land examples should be changed to the design package examples pattern

Copy link
Member

@griest024 griest024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very little of this component is actually specific to a text area beyond the selector and perhaps some of the styles. Would this be better suited to a more generalized focus directive and a CSS class?

/**
* Has the form been submitted.
*/
@Input() formSubmitted: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is never used; it should be removed.

@xelaint
Copy link
Member

xelaint commented Sep 8, 2021

@griest024 this component should not have been built without the form field's refactor. I think the input, select, and textarea components will heavily depend on the fixing up form field.

@xelaint xelaint closed this Dec 7, 2021
@damienwebdev damienwebdev deleted the design_textarea branch September 11, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants