Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): remove error message dependency on form-field #553

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 14, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

daff-error-message depends on daff-form-field. It cannot be used if we create a daff-solo-field component.

Part of: #416

What is the new behavior?

Move daff-error-message outside of daff-form-field and create its module so that it can be used in other form components.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@xelaint xelaint added the package: design @daffodil/design label Jan 14, 2020
@xelaint xelaint requested a review from a team as a code owner January 14, 2020 05:29
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the error message have a public api? Should it be exported?

Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 6c4ca03 into develop Jan 21, 2020
@damienwebdev damienwebdev deleted the error-message_update branch January 30, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

2 participants