Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): initialized DaffRadioComponent #815

Merged
merged 3 commits into from
May 27, 2020
Merged

Conversation

Nolan-Arnold
Copy link
Contributor

@Nolan-Arnold Nolan-Arnold commented Apr 15, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, the component kit doesn't have a design for the HTML radio UI component.

Fixes: #781
Part of: #416

What is the new behavior?

This adds a radio and radio-set component that allow users to create radios for forms in their applications.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Nolan-Arnold Nolan-Arnold marked this pull request as ready for review April 20, 2020 16:27
@Nolan-Arnold Nolan-Arnold requested a review from a team as a code owner April 20, 2020 16:27
@damienwebdev damienwebdev requested review from xelaint and damienwebdev and removed request for xelaint and damienwebdev April 21, 2020 20:57
@xelaint xelaint added the package: design @daffodil/design label Apr 22, 2020
@xelaint
Copy link
Member

xelaint commented Apr 22, 2020

The radioset component name should be updated to radio-set

DaffRadiosetModule -> DaffRadioSetModule
DaffRadiosetComponent -> DaffRadioSetComponent

The radio files are named incorrectly? should be radio.component.html, radio.component.scss, radio.component.spec.ts

@xelaint
Copy link
Member

xelaint commented Apr 22, 2020

@damienwebdev Should I do the style updates in the same PR or branch off?

libs/design/src/atoms/form/radio/radio.component.ts Outdated Show resolved Hide resolved
libs/design/src/atoms/form/radio/radio.component.ts Outdated Show resolved Hide resolved
libs/design/src/atoms/form/radio/radio.component.ts Outdated Show resolved Hide resolved
libs/design/src/atoms/form/radio/radio.component.ts Outdated Show resolved Hide resolved
libs/design/src/atoms/form/radioset/radioset.component.ts Outdated Show resolved Hide resolved
libs/design/src/atoms/form/radioset/radioset.component.ts Outdated Show resolved Hide resolved
libs/design/src/atoms/form/radio/radio.component.ts Outdated Show resolved Hide resolved
libs/design/src/atoms/form/radio/radio.component.ts Outdated Show resolved Hide resolved
libs/design/src/atoms/form/radio/radio.spec.ts Outdated Show resolved Hide resolved
libs/design/src/atoms/form/radioset/radioset.module.ts Outdated Show resolved Hide resolved
libs/design/src/atoms/form/radioset/radioset.component.ts Outdated Show resolved Hide resolved
libs/design/src/atoms/form/radio/radio.module.ts Outdated Show resolved Hide resolved
apps/design-land/src/app/radio/radio.component.ts Outdated Show resolved Hide resolved
@xelaint
Copy link
Member

xelaint commented Apr 28, 2020

Can you also update the radio-set file names accordingly?

@Nolan-Arnold Nolan-Arnold force-pushed the design-radio branch 2 times, most recently from 4ca62c6 to e127828 Compare May 12, 2020 19:40
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 86b0894 into develop May 27, 2020
@Nolan-Arnold Nolan-Arnold deleted the design-radio branch May 27, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
Development

Successfully merging this pull request may close these issues.

[FEAT] DaffRadioComponent and DaffRadioSetComponent
3 participants