-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design): initialized DaffRadioComponent #815
Conversation
The
The radio files are named incorrectly? should be radio.component.html, radio.component.scss, radio.component.spec.ts |
@damienwebdev Should I do the style updates in the same PR or branch off? |
Can you also update the |
4ca62c6
to
e127828
Compare
e127828
to
74473f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the component kit doesn't have a design for the HTML radio UI component.
Fixes: #781
Part of: #416
What is the new behavior?
This adds a
radio
andradio-set
component that allow users to create radios for forms in their applications.Does this PR introduce a breaking change?
Other information