-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9739 & #9760: Fix - Dependency management of widgets #9803
#9739 & #9760: Fix - Dependency management of widgets #9803
Conversation
…ent of widgets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix works, anyway the code have to be a little reorganized and cleaned up, or it is diffcoult to read and maintain.
Please follow my suggestions @dsuren1 .
I'm asking this for master only I think.
@offtherailz As part of this PR, I have removed just the requirement of the presence of an Example |
@dsuren1 it looks correct the way you did, from the user point of view. The ID of the widget should not be required to be dependent, so also new widget while editing first time can have a consistent preview.. |
@ElenaGallo please test in DEV and let us know. there are 2 issues connected to this PR and one of them is also for 2023.02.02 |
Test passed, @dsuren1 please backport to 2023.02.xx. Thanks |
@ElenaGallo probably nothing to be backported for this. I'm waiting confirmation from @dsuren1. |
@dsuren1 thank you for the confirmation. |
Description
This PR attempts to fix the issue with the dependency management of widgets
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
What is the new behavior?
Test data
/dashboard/47595
/dashboard/47592
/dashboard/47714
Screenshot
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information