Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets connections no longer work as expected in DEV #9760

Closed
1 task done
tdipisa opened this issue Nov 28, 2023 · 1 comment · Fixed by #9803
Closed
1 task done

Widgets connections no longer work as expected in DEV #9760

tdipisa opened this issue Nov 28, 2023 · 1 comment · Fixed by #9803

Comments

@tdipisa
Copy link
Member

tdipisa commented Nov 28, 2023

Description

Charts widgets connection no longer works as expected in DEV (probably due to the chart refactor we have done recently). When you try to connect a chart widget to a map or table widget there are two problems:

1 - There is a wrong tooltip in the connection button
image

2 - There is no choice to decide which widget to connect in case both table and map widgets are present in the dashboard

How to reproduce

  • Open this dashboard
  • Try to change connection of a chart widget by opening its wizard

Expected Result

As happens in QA and current release

qa_chart

Current Result

In DEV there is the regression (same dashboard)

dev_chart

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

The ACs listed in #4149 should be all checked again because, for example, the following one is no loner respected:

A Parent Table cannot be connected to another Table widget and cannot be connected to a Map widget

and possibly restore the correct state through this issue.

@tdipisa
Copy link
Member Author

tdipisa commented Dec 5, 2023

It seems definitely something from #4149 has been broken. For example one of the ACs in that issue says:

A Parent Table cannot be connected to another Table widget and cannot be connected to a Map widget

but in the linked dashboard in description, the States Map is connected to the States Table (PT) and now you can also connect at the same time the PT to the States Map. It should not be allowed as per original ACs.

I've updated the description mentioning this.

@tdipisa tdipisa changed the title Charts widgets connection no longer works as expected in DEV Widgets connection no longer works as expected in DEV Dec 5, 2023
@tdipisa tdipisa changed the title Widgets connection no longer works as expected in DEV Widgets connections no longer work as expected in DEV Dec 5, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Dec 7, 2023
@dsuren1 dsuren1 linked a pull request Dec 7, 2023 that will close this issue
5 tasks
@ElenaGallo ElenaGallo self-assigned this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants