Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect connection of the parent table with the map and another widget #9739

Closed
1 task done
ElenaGallo opened this issue Nov 23, 2023 · 8 comments · Fixed by #9803 or #9804
Closed
1 task done

Incorrect connection of the parent table with the map and another widget #9739

ElenaGallo opened this issue Nov 23, 2023 · 8 comments · Fixed by #9803 or #9804

Comments

@ElenaGallo
Copy link
Contributor

Description

As reported in the User Guide here, if the widget has been created on the same dataset (layer) of the Parent Table then two filters will be applied in AND to the widget itself: the spatial filter of the Map widget and the attribute filter defined in the Parent Table.

At this moment this type of connection is not correct. The chart widget is connected to the map but not to the Parent Table.

How to reproduce

Expected Result

interaction_ok.mp4

Current Result

interaction_no.mp4
  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@MV88
Copy link
Contributor

MV88 commented Nov 27, 2023

there is problem with the introduction of traces and propagation of dependencies, I've spotted a problem here

image

in particular the fetch of table deps from a trace

https://github.com/geosolutions-it/MapStore2/blob/master/web/client/selectors/widgets.js#L113

i suppose it is enough to properly fix this selector, but i had no time to check it.
if it this the case it should be a quick fix otherwise it may take some more effort

@tdipisa tdipisa added this to the 2023.02.01 milestone Nov 28, 2023
@tdipisa
Copy link
Member

tdipisa commented Nov 28, 2023

This is a regression imho since it seems affecting also QA. @MV88 @ElenaGallo please confirm.

@tdipisa tdipisa modified the milestones: 2023.02.01, 2023.02.02 Nov 28, 2023
@tdipisa tdipisa assigned dsuren1 and unassigned MV88 Nov 28, 2023
@MV88
Copy link
Contributor

MV88 commented Nov 28, 2023

yeah, it has been introduced with multivariable charts work

@tdipisa
Copy link
Member

tdipisa commented Nov 28, 2023

@MV88

yeah, it has been introduced with multivariable charts work

it is not possible since that work is not present in QA but only in DEV, therefore I think the source of the problem is another. Anyway let's better check what introduce this regression @dsuren1.

@MV88
Copy link
Contributor

MV88 commented Nov 28, 2023

ok, anyway there it fails because it does not find the editing layer in the charts, dues to the introduction of traces.

@dsuren1
Copy link
Contributor

dsuren1 commented Nov 30, 2023

Investigation

The regression was introduced in 2021.02.00 by #7376 in buildDependencies function stop from building a correct dependency recursively.

Removing the condition of !ret.mapSync from buildDependencies allows us to propogate the dependency properly and fixes this issue. But it reintroduces the Maximum call stack size exceeded exception, so we need to find a better way to handle both the scenarios

Investigation was made against the current stable 2023.02.xx, same could be applied to DEV as well.

Although as @MV88 higlighted, there is some problem in the selector in DEV availableDependenciesForEditingWidgetSelector with respect to traces, which needs to be checked separately, for any other issues apart from the current one

@tdipisa
Copy link
Member

tdipisa commented Nov 30, 2023

@dsuren1 should we review pts assigned to this issue ?

@dsuren1
Copy link
Contributor

dsuren1 commented Nov 30, 2023

Yes @tdipisa, maybe a point more should help us better identify the cause for intial change and find a common ground to fix both issues without breaking new changes. Furthermore the investigation took some time in tracing and finding the root cause.

dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Dec 7, 2023
@dsuren1 dsuren1 linked a pull request Dec 7, 2023 that will close this issue
5 tasks
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Dec 7, 2023
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 20, 2023
@ElenaGallo ElenaGallo self-assigned this Jan 15, 2024
@ElenaGallo ElenaGallo added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment