Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup interviews #924

Merged
merged 60 commits into from
Jan 1, 2024

Conversation

krantheman
Copy link
Member

@krantheman krantheman commented Sep 28, 2023

Issue

Closes: #781

Changes

  • Redid Feedback section of the Interview DocType
    • Eliminated data duplication by removing average rating, result, and other fields from the Interview Detail table. This table only has an Interviewer link field now.
    • Added a Feedback tab that summarizes and displays data directly from Interview Feedback
  • Made Interview Type optional for Interview Round
  • Updated applicable interviewers to default to Interview Round Interviewers
  • Updated Submit Feedback button in Interview to be disabled, but visible, for unauthorized users (as opposed to not being rendered at all)
  • Fixed issue where cancellation of an individual Interview Feedback required all docs of the same Interview to be cancelled
  • Removed unnecessary overlap validation to allow for more flexibility
  • Updated tests to reflect changes
  • Updated Appraisal -> Feedback tab to use the same feedback summary & history templates as Interview -> Feedback

image

Documentation

https://frappehr.com/docs/v14/en/interview-management

@krantheman krantheman changed the title Cleanup interviews refactor: cleanup interviews Sep 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (dfb9712) 72.48% compared to head (f935cb3) 72.26%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #924      +/-   ##
===========================================
- Coverage    72.48%   72.26%   -0.22%     
===========================================
  Files          201      201              
  Lines        10946    10941       -5     
===========================================
- Hits          7934     7907      -27     
- Misses        3012     3034      +22     
Files Coverage Δ
hrms/hooks.py 100.00% <ø> (ø)
...ms/hr/doctype/interview_detail/interview_detail.py 100.00% <ø> (ø)
...r/doctype/interview_feedback/interview_feedback.py 93.18% <100.00%> (-0.94%) ⬇️
hrms/hr/doctype/interview_round/interview_round.py 38.88% <0.00%> (ø)
hrms/hr/doctype/job_applicant/job_applicant.py 64.28% <0.00%> (ø)
hrms/hr/doctype/interview/interview.py 64.41% <88.00%> (+0.44%) ⬆️

... and 7 files with indirect coverage changes

@ruchamahabal
Copy link
Member

ruchamahabal commented Oct 3, 2023

  • make the feedback cards tighter - reduce padding
  • star distribution chart - remove colors - convert to gray (like appraisal feedback summary)
  • Font size for chart labels & rating - looks bigger than feedback font
  • Rating summary header font sizes should be consistent with section heading sizes
  • Tighter spacing in summary - between "based on x reviews" and the stars

Extra:

  • Reuse/change appraisal feedback template
  • Reduce spacing between section title & description
image

@ruchamahabal ruchamahabal merged commit e54baa4 into frappe:develop Jan 1, 2024
5 of 6 checks passed
@ruchamahabal
Copy link
Member

@Mergifyio backport version-15-hotfix

Copy link
Contributor

mergify bot commented Jan 1, 2024

backport version-15-hotfix

❌ No backport have been created

  • Backport to branch version-15-hotfix failed

Git reported the following error:

error: commit 0ff94289cd53513b18ff88dd8e257aadc89bccee is a merge but no -m option was given.
fatal: cherry-pick failed

@ruchamahabal
Copy link
Member

@Mergifyio copy version-15-hotfix

Copy link
Contributor

mergify bot commented Jan 1, 2024

copy version-15-hotfix

❌ No copy have been created

  • Copy to branch version-15-hotfix failed

Git reported the following error:

error: commit 0ff94289cd53513b18ff88dd8e257aadc89bccee is a merge but no -m option was given.
fatal: cherry-pick failed

@ruchamahabal
Copy link
Member

@krantheman can you open a PR on v15 hotfix

@krantheman krantheman deleted the cleanup-interviews branch January 1, 2024 06:47
Copy link
Contributor

mergify bot commented Jan 1, 2024

⚠️ The sha of the head commit of this PR conflicts with #1243. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Cleanup interviews
3 participants