Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup interviews (backport #924) #1243

Conversation

krantheman
Copy link
Member

This is a backport of pull request #924

ruchamahabal and others added 30 commits October 26, 2023 16:55
…pe#1005)

* feat:Add Unselect all in Mark Attendance Dialog

* chore: fix formatting

---------

Co-authored-by: Rucha Mahabal <[email protected]>
feat: Add sender in Payroll Settings & HR Settings
perf: batch and commit auto attendance processing
- android ionic styles are ugly 🥲
feat(PWA): misc improvements & fixes
frappe#1021)

* Added default permission for HR Manager to submit F&F Statement

* chore: fix incorrect json

* chore: update modified timestamp

---------

Co-authored-by: Rucha Mahabal <[email protected]>
feat(PWA): File previews & better file/attachment handling
ruchamahabal and others added 22 commits December 29, 2023 11:53
test: fix flaky tests + related refactors
* feat: Create new doctype for offer term

* fix: Update job offer

* feat: Add title field in term template

* fix: add default perm for HR Manager, clear table on selecting template

- fix naming, child table fieldnames should be plural

---------

Co-authored-by: Rucha Mahabal <[email protected]>
- to avoid breaking change
- `run_doc_method` on cancelled document errors out
- add common html templates in main bundle
- retain interviewer mapping in child table in APIs
- user has to enter all fields again

- before sending rescheduling email check if timings have changed
@mergify mergify bot mentioned this pull request Jan 1, 2024
@krantheman krantheman marked this pull request as draft January 1, 2024 09:39
@ruchamahabal
Copy link
Member

backported with lesser bloat: #1249

closing this

@krantheman krantheman deleted the cleanup-interviews-version-15-hotfix branch January 4, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.