Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup interviews #924

Merged
merged 60 commits into from
Jan 1, 2024
Merged

refactor: cleanup interviews #924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
3d2865d
refactor(Interview Round): make Interview Type optional
krantheman Sep 18, 2023
07fd012
feat: add Feedback Tab
krantheman Sep 20, 2023
44bde3b
feat: pull feedback data from server
krantheman Sep 20, 2023
9e999e5
feat: add ratings summary
krantheman Sep 22, 2023
61b2520
refactor: calculate reviews per rating based on user average rating
krantheman Sep 22, 2023
11ed8f5
feat: add individual ratings
krantheman Sep 25, 2023
8b13121
refactor: clean up feedback summary
krantheman Sep 25, 2023
389f4c8
feat: add circular progress bar
krantheman Sep 25, 2023
77082ed
feat: dynamic circular progress bar
krantheman Sep 26, 2023
5e17df1
refactor: get appllicable interviewers
krantheman Sep 26, 2023
79e4465
feat: use circular progress bar for skills
krantheman Sep 26, 2023
476e465
feat: consider colors for ratings between 0 and 1
krantheman Sep 26, 2023
47fe4e5
fix: circular progress size
krantheman Sep 26, 2023
e310415
refactor: disable Submit Feedback for unauthorized users
krantheman Sep 26, 2023
5314b38
feat: update interview average rating on submitting feedback
krantheman Sep 27, 2023
b793e93
refactor: clean up interview_details
krantheman Sep 27, 2023
837c1c1
test: clean up instances of interview_detail
krantheman Sep 27, 2023
f7ac74a
chore: delete redundant doctype Interview Detail
krantheman Sep 27, 2023
4b5d6b2
refactor: better querying
krantheman Sep 27, 2023
f7986bf
fix: Feedback rendering of new Interviews
krantheman Sep 28, 2023
3dc7641
fix: No feedback message
krantheman Sep 28, 2023
0553c71
fix: rounding
krantheman Sep 28, 2023
0c8c05a
chore: remove unused import
krantheman Sep 28, 2023
d830b6a
fix: Feedback Summary subtext
krantheman Sep 28, 2023
c0912e6
chore: convert spaces to tabs ...again
krantheman Sep 28, 2023
8f53b54
chore: improve readability
krantheman Sep 28, 2023
a82f9d4
style: change rating colors to gray
krantheman Oct 3, 2023
6c54ba1
fix: font size and spacing
krantheman Oct 3, 2023
4234336
refactor: performance feedback summary
krantheman Oct 3, 2023
4dde7fe
refactor: use common feedback_history and feedback_summary
krantheman Oct 6, 2023
850ece8
fix(Appraisal): Employee Performance Feedback link
krantheman Oct 6, 2023
79cf233
refactor: clean up feedback_history context
krantheman Oct 6, 2023
f4574d4
chore: rename performance_feedback_history to performance_feedback
krantheman Oct 6, 2023
88a58e3
fix(circular_progress): file name typo
krantheman Oct 6, 2023
f65f5cc
feat: add Interviewers field which automatically fetches interviewers…
krantheman Nov 20, 2023
f7990cf
refactor: consider Interviewers selected in Interview rather than fro…
krantheman Nov 21, 2023
e0f00e1
refactor: use Table instead of Table MultiSelect for Interviewers
krantheman Nov 23, 2023
0ff9428
chore: merge with develop and fix conflicts
krantheman Nov 28, 2023
3af0ccb
chore: convert map to list comprehension
krantheman Nov 28, 2023
378857d
test: fix Interviewers
krantheman Nov 30, 2023
2fdd318
chore: fix formatting
krantheman Dec 19, 2023
aafb6e6
Merge branch 'develop' into cleanup-interviews
ruchamahabal Dec 25, 2023
6ada2a7
Merge branch 'develop' into cleanup-interviews
ruchamahabal Dec 29, 2023
6ee0712
refactor: retain interview detail doctype
ruchamahabal Dec 29, 2023
2917a46
fix: fetching applicable interviewers for interview & feedback
ruchamahabal Dec 29, 2023
9be20dd
refactor: move fetch fields to `fetch_from` config, cleanup js contro…
ruchamahabal Dec 30, 2023
7bcd3a2
fix: move whitelisted getter functions outside class
ruchamahabal Dec 30, 2023
fab8b18
perf: remove lazy-loaded bundles from app include js
ruchamahabal Dec 30, 2023
dc62f11
fix: run feedback functions serially
ruchamahabal Dec 30, 2023
501a41b
fix: don't break whitelisted API
ruchamahabal Dec 31, 2023
fe0f9cd
test: fix interview tests
ruchamahabal Dec 31, 2023
8ecd8b7
feat: show hover message for disabled feedback submission
ruchamahabal Dec 31, 2023
4efee05
chore: cleanup templates
ruchamahabal Dec 31, 2023
e48a0c5
feat: set current interview timings as default while rescheduling
ruchamahabal Dec 31, 2023
285c2a2
fix: notify update after updating average rating in interview
ruchamahabal Dec 31, 2023
30e4f62
fix: move Reschedule Interview to Actions
ruchamahabal Dec 31, 2023
7171f50
fix: use left join in interview feedback query to fetch feedback from…
ruchamahabal Dec 31, 2023
3309c6b
test(APIs): `get_feedback` & `get_skill_wise_average_rating`
ruchamahabal Dec 31, 2023
f935cb3
chore: remove unused col break
ruchamahabal Dec 31, 2023
5bfca12
chore: allow updating interview detail on submission
ruchamahabal Jan 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion hrms/hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# app_include_css = "/assets/hrms/css/hrms.css"
app_include_js = [
"hrms.bundle.js",
"performance.bundle.js",
]
app_include_css = "hrms.bundle.css"

Expand Down
2 changes: 1 addition & 1 deletion hrms/hr/doctype/attendance_request/test_attendance_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def test_skip_attendance_on_leave(self):
leave_type=leave_type.name, from_date=self.from_date, to_date=self.to_date
)
today = getdate()
make_leave_application(self.employee.name, today, add_days(today, 1), leave_type.name)
make_leave_application(self.employee.name, today, today, leave_type.name)

attendance_request = create_attendance_request(
employee=self.employee.name, reason="On Duty", company="_Test Company"
Expand Down
Loading
Loading