Update all instances of MinimumPreferenceOccurances to directly use TransitionCriterion #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52852317 |
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 17, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 17, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 18, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 18, 2024
…ransitionCriterion (facebook#2135) Summary: X-link: facebookresearch/aepsych#327 We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 19, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 19, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 19, 2024
…ransitionCriterion (facebook#2135) Summary: X-link: facebookresearch/aepsych#327 We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 19, 2024
…ransitionCriterion (facebook#2135) Summary: X-link: facebookresearch/aepsych#327 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 19, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Differential Revision: D52852317
mgarrard
force-pushed
the
export-D52852317
branch
from
801ede2
to
3401268
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52852317 |
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 22, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 24, 2024
…ransitionCriterion (facebook#2135) Summary: X-link: facebookresearch/aepsych#327 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 24, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52852317
mgarrard
force-pushed
the
export-D52852317
branch
from
3401268
to
47ed730
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52852317 |
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 24, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 26, 2024
…ransitionCriterion (facebook#2135) Summary: X-link: facebookresearch/aepsych#327 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52852317
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 26, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52852317
mgarrard
force-pushed
the
export-D52852317
branch
from
47ed730
to
05a6d87
Compare
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 26, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52852317
|
This pull request was exported from Phabricator. Differential Revision: D52852317 |
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52852317
mgarrard
force-pushed
the
export-D52852317
branch
from
05a6d87
to
2f76d8f
Compare
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 29, 2024
…ransitionCriterion (facebook#2135) Summary: X-link: facebookresearch/aepsych#327 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52852317
|
This pull request was exported from Phabricator. Differential Revision: D52852317 |
mgarrard
added a commit
to mgarrard/aepsych
that referenced
this pull request
Jan 29, 2024
…ransitionCriterion (facebookresearch#327) Summary: X-link: facebook/Ax#2135 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52852317
|
This pull request has been merged in 1aa4280. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Jan 29, 2024
…ransitionCriterion (#2135) Summary: Pull Request resolved: #2135 X-link: facebookresearch/aepsych#327 This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Reviewed By: lena-kashtelyan Differential Revision: D52852317 fbshipit-source-id: 357ae081a0d2ceb83bc7376cb9144141f6b13f58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file
In following diffs we will:
Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing
Differential Revision: D52852317