Skip to content

Commit

Permalink
Update all instances of MinimumPreferenceOccurances to directly use T…
Browse files Browse the repository at this point in the history
…ransitionCriterion (facebookresearch#327)

Summary:
X-link: facebook/Ax#2135


We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion MinTrials. This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file

In following diffs we will:
- Completely remove the completion criterion file
- update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15
- revisit storage
- remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code
- update AEPsych GSs as needed
- determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true

Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing

Differential Revision: D52852317
  • Loading branch information
mgarrard authored and facebook-github-bot committed Jan 19, 2024
1 parent d6a1e20 commit 90fe36b
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from aepsych.config import Config, ConfigurableMixin

from ax.modelbridge.completion_criterion import MinimumPreferenceOccurances
from ax.modelbridge.transition_criterion import MinimumPreferenceOccurances


class MinTotalOutcomeOccurrences(MinimumPreferenceOccurances, ConfigurableMixin):
Expand Down

0 comments on commit 90fe36b

Please sign in to comment.