Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all instances of MinimumPreferenceOccurances to directly use TransitionCriterion #327

Closed
wants to merge 1 commit into from

Commits on Jan 29, 2024

  1. Update all instances of MinimumPreferenceOccurances to directly use T…

    …ransitionCriterion (facebookresearch#327)
    
    Summary:
    X-link: facebook/Ax#2135
    
    
    This diff updates MinimumPreferenceOccurances to directly inherit from its source in TransitionCriterion file
    
    In following diffs we will:
    - Completely remove the completion criterion file
    - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15
    - revisit storage
    - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code
    - update AEPsych GSs as needed
    - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true
    
    Reviewed By: lena-kashtelyan
    
    Differential Revision: D52852317
    mgarrard authored and facebook-github-bot committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    2f76d8f View commit details
    Browse the repository at this point in the history