Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegatable resolver with factory #289

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Delegatable resolver with factory #289

merged 7 commits into from
Nov 1, 2023

Conversation

makoto
Copy link
Member

@makoto makoto commented Oct 30, 2023

No description provided.

Arachnid
Arachnid requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@Arachnid Arachnid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can update to the latest version of my PR, there's a couple of function name changes too.

contracts/resolvers/DelegatableResolver.sol Outdated Show resolved Hide resolved
contracts/resolvers/DelegatableResolver.sol Outdated Show resolved Hide resolved
contracts/resolvers/DelegatableResolverFactory.sol Outdated Show resolved Hide resolved
contracts/resolvers/DelegatableResolverFactory.sol Outdated Show resolved Hide resolved
@makoto
Copy link
Member Author

makoto commented Nov 1, 2023

@jefflau @Arachnid PTAL

@makoto makoto mentioned this pull request Nov 1, 2023
Open
@makoto
Copy link
Member Author

makoto commented Nov 1, 2023

If you can update to the latest version of my PR, there's a couple of function name changes too.

You mean https://github.com/wighawag/clones-with-immutable-args/pull/19/commits ? It only has one commit. Did you push your change?

@makoto makoto merged commit 9ae2281 into delegatable-resolver-wo-factory Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefflau jefflau jefflau left review comments

@Arachnid Arachnid Arachnid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makoto @Arachnid @jefflau