Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegatable resolver with factory #289

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Delegatable resolver with factory #289

merged 7 commits into from
Nov 1, 2023

Commits on Oct 30, 2023

  1. Use Factory

    @makoto
    makoto committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b639685 View commit details
    Browse the repository at this point in the history

  2. Add description and more tests

    @makoto
    makoto committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    e03e212 View commit details
    Browse the repository at this point in the history

  3. Add check to prevent people from using the resolver without owner

    @makoto
    makoto committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    cb56a0b View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Nick Johnson <[email protected]>
Co-authored-by: Jeff Lau <[email protected]>
    @makoto @Arachnid @jefflau
    3 people authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    56cd62b View commit details
    Browse the repository at this point in the history

  2. Fix broken tests

    @makoto
    makoto committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3843354 View commit details
    Browse the repository at this point in the history

  3. Remove owner check

    @makoto
    makoto committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    470603b View commit details
    Browse the repository at this point in the history

  4. Resolve conflicts

    @makoto
    makoto committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3a3f4f9 View commit details
    Browse the repository at this point in the history