Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegatable resolver #288

Open
wants to merge 21 commits into
base: staging
Choose a base branch
from
Open

Delegatable resolver #288

wants to merge 21 commits into from

Conversation

makoto
Copy link
Member

@makoto makoto commented Oct 30, 2023

The Delegatable Reolver allows the resolver owner to add an operator to update records of a node on behalf of the owner.

It is going to be created by a factory contract every time a user set up a resolver on L2. The owner can grant operator to any names including subnames.

@makoto makoto changed the title Delegatable resolver wo factory Delegatable resolver without factory Oct 30, 2023
@makoto
Copy link
Member Author

makoto commented Oct 30, 2023

PTAL @Arachnid

@Arachnid
Copy link
Member

Arachnid commented Nov 1, 2023

Is this PR now obsolete?

@makoto
Copy link
Member Author

makoto commented Nov 1, 2023

Is this PR now obsolete?

No, it is not osbolute. #289 is to merge the branch into this branch

makoto and others added 2 commits November 1, 2023 12:40
* Use Factory

* Add description and more tests

* Add check to prevent people from using the resolver without owner

* Apply suggestions from code review

Co-authored-by: Nick Johnson <[email protected]>
Co-authored-by: Jeff Lau <[email protected]>

* Fix broken tests

* Remove owner check

---------

Co-authored-by: Nick Johnson <[email protected]>
Co-authored-by: Jeff Lau <[email protected]>
@makoto makoto changed the title Delegatable resolver without factory Delegatable resolver Nov 1, 2023
@Chomtana
Copy link

Chomtana commented Apr 4, 2024

So, we should use this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants