-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Always allocate when computing temp path #81085
Conversation
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsCloses #73721
|
/azp run runtime-wasm-libtests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm-libtests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm-libtests |
Azure Pipelines successfully started running 1 pipeline(s). |
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4016125533 |
Emscripten landed fix for it emscripten-core/emscripten#18914 perhaps we could revert this change after we receive the new emscripten version |
The wasm implementation of
__randname
uses pointer address as another entry into the randomness.https://github.com/emscripten-core/emscripten/blob/085fe968d43c7d3674376f29667d6e5f42b24966/system/lib/libc/musl/src/temp/__randname.c#L13
We may get the same random name if the same pointer passed twice before the clock ticks. The issue in the upstream repository is emscripten-core/emscripten#18591.
We have decided to take the simplest solution at the moment and consider a better one as part of the WASI file system implementation #81210
Fixes #73721