Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Always allocate when computing temp path #81085

Merged
merged 3 commits into from
Jan 26, 2023
Merged

[wasm] Always allocate when computing temp path #81085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
495a5ef
Always allocation on wasm when computing temp path.
maraf Jan 24, 2023
2005584
Enable tests.
maraf Jan 25, 2023
96e2b1b
Add link to emscripten issue and describe why we allocate on heap.
maraf Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/libraries/System.CodeDom/tests/System/CodeDom/Compiler/CodeCompilerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ public void CompileAssemblyFromDom_NullOptions_ThrowsArgumentNullException()

[Theory]
[MemberData(nameof(CodeCompileUnit_TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73721", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJSOnWindows))]
public void FromDom_ValidCodeCompileUnit_ReturnsExpected(CodeCompileUnit compilationUnit)
{
var compiler = new StubCompiler();
Expand All @@ -67,7 +66,6 @@ public void FromDom_ValidCodeCompileUnit_ReturnsExpected(CodeCompileUnit compila
[Theory]
[MemberData(nameof(CodeCompileUnit_TestData))]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73721", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJSOnWindows))]
public void FromDom_ValidCodeCompileUnit_ThrowsPlatformNotSupportedException(CodeCompileUnit compilationUnit)
{
var compiler = new Compiler();
Expand Down Expand Up @@ -363,7 +361,6 @@ public void CompileAssemblyFromSource_NullOptions_ThrowsArgumentNullException()
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73721", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJSOnWindows))]
[MemberData(nameof(Source_TestData))]
public void FromSource_ValidSource_ReturnsExpected(string source)
{
Expand All @@ -374,7 +371,6 @@ public void FromSource_ValidSource_ReturnsExpected(string source)
[Theory]
[MemberData(nameof(Source_TestData))]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73721", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJSOnWindows))]
public void FromSource_ValidSource_ThrowsPlatformNotSupportedException(string source)
{
var compiler = new Compiler();
Expand All @@ -398,7 +394,6 @@ public static IEnumerable<object[]> Sources_TestData()

[Theory]
[MemberData(nameof(Sources_TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73721", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJSOnWindows))]
public void CompileAssemblyFromSourceBatch_ValidSources_ReturnsExpected(string[] sources)
{
ICodeCompiler compiler = new StubCompiler();
Expand Down Expand Up @@ -430,7 +425,6 @@ public void CompileAssemblyFromSourceBatch_NullSources_ThrowsArgumentNullExcepti

[Theory]
[MemberData(nameof(Sources_TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73721", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJSOnWindows))]
public void FromSourceBatch_ValidSources_ReturnsExpected(string[] sources)
{
var compiler = new StubCompiler();
Expand All @@ -440,7 +434,6 @@ public void FromSourceBatch_ValidSources_ReturnsExpected(string[] sources)
[Theory]
[MemberData(nameof(Sources_TestData))]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73721", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJSOnWindows))]
public void FromSourceBatch_ValidSources_ThrowsPlatformNotSupportedException(string[] sources)
{
var compiler = new Compiler();
Expand All @@ -466,7 +459,6 @@ public void FromSourceBatch_NullSources_ThrowsArgumentNullException()
[InlineData("")]
[InlineData("cmdArgs")]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Occasionally fails in .NET framework, probably caused from a very edge case bug in .NET Framework which we will not be fixing")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73721", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJSOnWindows))]
public void GetResponseFileCmdArgs_ValidCmdArgs_ReturnsExpected(string cmdArgs)
{
var compiler = new Compiler();
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Diagnostics.TextWriterTraceListener/tests/CtorsDelimiterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ public void TestConstructorWithFileName()

[Theory]
[MemberData(nameof(TestNames))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73721", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJSOnWindows))]
public void TestConstructorWithFileNameAndName(string testName)
{
var target = new DelimitedListTraceListener(Path.GetTempFileName(), testName);
Expand Down
1 change: 0 additions & 1 deletion ...libraries/System.Diagnostics.TextWriterTraceListener/tests/XmlWriterTraceListenerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public static IEnumerable<object[]> ConstructorsTestData()

[Theory]
[MemberData(nameof(ConstructorsTestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73721", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJSOnWindows))]
public void SingleArgumentConstructorTest(XmlWriterTraceListener listener, string expectedName)
{
Assert.Equal(expectedName, listener.Name);
Expand Down
6 changes: 6 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/IO/Path.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,13 @@ public static unsafe string GetTempFileName()
int tempPathByteCount = Encoding.UTF8.GetByteCount(tempPath);
int totalByteCount = tempPathByteCount + fileTemplate.Length + 1;

#if TARGET_BROWSER
// https://github.com/emscripten-core/emscripten/issues/18591
// The emscripten implementation of __randname uses pointer address as another entry into the randomness.
Span<byte> path = new byte[totalByteCount];
maraf marked this conversation as resolved.
Show resolved Hide resolved
maraf marked this conversation as resolved.
Show resolved Hide resolved
#else
Span<byte> path = totalByteCount <= 256 ? stackalloc byte[256].Slice(0, totalByteCount) : new byte[totalByteCount];
#endif
int pos = Encoding.UTF8.GetBytes(tempPath, path);
fileTemplate.CopyTo(path.Slice(pos));
path[^1] = 0;
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.ServiceModel.Syndication/tests/BasicScenarioTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public static void SyndicationFeed_CreateNewFeed()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/77526", TestPlatforms.Browser)]
public static void SyndicationFeed_Load_Write_RSS_Feed()
{
string path = Path.GetTempFileName();
Expand Down Expand Up @@ -178,7 +177,6 @@ public static void SyndicationFeed_Load_Write_Atom_Feed_()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73721", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJSOnWindows))]
public static void SyndicationFeed_Write_RSS_Atom()
{
string RssPath = Path.GetTempFileName();
Expand Down