[release/7.0] [wasm] Always allocate when computing temp path #81217
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #81085 to release/7.0 /cc @maraf Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
Your description does not describe customer impact. What are the customers going to see due to this bug? How likely it is that customers are going to run into this bug? Do we have any instances of this bug reported by customers? IMHO, this fix does not meet the bar for backport. The problem was identified by our tests that are stressing the API. It is unlikely to be hit by real apps. |
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #81085 to release/7.0 /cc @maraf Customer ImpactWASM uses emscripten's posix emulation for computing temp file name. It has a slight deviation from musl implementation and it also includes pointer address as another entry into the randomness. In the #73408 the heap allocation was replaced with stack allocation which causes problems when calling the function multiple times before clock ticks. This is a simplest change to introduce back the heap allocation on WASM platform. A more optimal solution will be reviewed as part of the WASI file system implementation. TestingUnit tests RiskNone IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
ghost
locked as resolved and limited conversation to collaborators
Backport of #81085 to release/7.0
/cc @maraf
Customer Impact
WASM uses emscripten's posix emulation for computing temp file name. It has a slight deviation from musl implementation and it also includes pointer address as another entry into the randomness.
In the #73408 the heap allocation was replaced with stack allocation which causes problems when calling the function multiple times before clock ticks.
This is a simplest change to introduce back the heap allocation on WASM platform. A more optimal solution will be reviewed as part of the WASI file system implementation.
Testing
Unit tests
Risk
None
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.