Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Async entity From Android #1386

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Adds Async entity From Android #1386

merged 2 commits into from
Nov 30, 2023

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Nov 29, 2023

Technical Summary

Moves async entity implementation from Android to core
Adds an interface for EntityStorageCache to facilitate the refactor

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

cross-request: dimagi/commcare-android#2732

@shubham1g5
Copy link
Contributor Author

duplicate this PR

Copy link
Contributor

@snopoke snopoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning for the move?

@shubham1g5
Copy link
Contributor Author

What's the reasoning for the move

We want to implement similar functionality on Formplayer to lazily load entity list fields for only the entities visible on a single page (https://dimagi-dev.atlassian.net/browse/USH-3790). This is more of a preliminary refactoring for that feature and will be followed by actual implmentation PR on Formplayer.

@shubham1g5 shubham1g5 merged commit ae7ea8d into formplayer Nov 30, 2023
2 checks passed
@shubham1g5 shubham1g5 deleted the asyncEntity branch November 30, 2023 15:43
@shubham1g5 shubham1g5 mentioned this pull request Dec 4, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants