Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Apps: Lazy loads case list #1388

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Web Apps: Lazy loads case list #1388

merged 5 commits into from
Dec 6, 2023

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Dec 4, 2023

Product Description

Spec

Implements a property "lazy_loading" in detail config to lazy load entity list fields

Builds on #1386

Safety Assurance

Safety story

  • Did staging testing by turning on lazy loading by default and did not catch any issues
  • Changes are behind a suite config flag so should not affect any existing apps

Automated test coverage

PR adds a test for model change, will complement the PR with some FP side tests soon

QA Plan

None

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

@shubham1g5 shubham1g5 changed the title Web Apps: Lazy load case list based on a property Web Apps: Lazy loads case list Dec 4, 2023
Copy link
Contributor

@MartinRiese MartinRiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about the code. But the changes look fairly straight forward to me. I don't see any issues here.

@shubham1g5 shubham1g5 marked this pull request as ready for review December 6, 2023 14:13
@shubham1g5 shubham1g5 merged commit 3648b76 into formplayer Dec 6, 2023
2 checks passed
@shubham1g5 shubham1g5 deleted the asyncEntityLoad branch December 6, 2023 14:14
@shubham1g5 shubham1g5 restored the asyncEntityLoad branch December 6, 2023 14:14
@shubham1g5
Copy link
Contributor Author

@shubham1g5 Need to duplicate after #1387 gets merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants