Duplicate of asyncEntity #1387
Merged
Duplicate of asyncEntity #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
3 tasks
3 tasks
|
@avazirna @ctsims pinging for review. I'm hoping to get some of these duplicate PRs merged while Shubham is away. There are a few backlogged where one depends on the previous being merged. This is the first of those. |
avazirna
reviewed
Apr 8, 2024
Comment on lines
126
to
162
| synchronized (mAsyncLock) { | ||
| if (sortData[i] == null) { | ||
| // sort data not in search field cache; load and store it | ||
| Text sortText = fields[i].getSort(); | ||
| if (sortText == null) { | ||
| mEntityStorageCache.releaseCache(); | ||
| return null; | ||
| } | ||
|
|
||
| String cacheKey = mEntityStorageCache.getCacheKey(mDetailId, String.valueOf(i)); | ||
|
|
||
| if (mCacheIndex != null) { | ||
| //Check the cache! | ||
| String value = mEntityStorageCache.retrieveCacheValue(mCacheIndex, cacheKey); | ||
| if (value != null) { | ||
| this.setSortData(i, value); | ||
| mEntityStorageCache.releaseCache(); | ||
| return sortData[i]; | ||
| } | ||
| } | ||
|
|
||
| loadVariableContext(); | ||
| try { | ||
| sortText = fields[i].getSort(); | ||
| if (sortText == null) { | ||
| this.setSortData(i, getFieldString(i)); | ||
| } else { | ||
| this.setSortData(i, StringUtils.normalize(sortText.evaluate(context))); | ||
| } | ||
|
|
||
| mEntityStorageCache.cache(mCacheIndex, cacheKey, sortData[i]); | ||
| } catch (XPathException xpe) { | ||
| Logger.exception("Error while evaluating sort field", xpe); | ||
| xpe.printStackTrace(); | ||
| sortData[i] = "<invalid xpath: " + xpe.getMessage() + ">"; | ||
| } | ||
| } |
There was a problem hiding this comment.
This code was previously wrapped around a try..finally block, which would close the transaction no matter the outcome. How certain are we that this code will always be successful?
avazirna
approved these changes
Apr 10, 2024
|
duplicate this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of PR #1386
GitHub Actions automatically ran duplicate_pr.py and used GitHub CLI to open this pull request.
Please close and reopen this pull request to have tests run.†
† Workaround for this GitHub Actions constraint