[ADAP-849] removes some user connection details from stdout #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that we don't want showing up in dbt debug commands
…flake into mcknight/ADAP-849
colin-rogers-dbt
approved these changes
Aug 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 28, 2023
* update RELEASE_BRANCH env * remove some connection fields that may be sensitive user information that we don't want showing up in dbt debug commands * add changelog and comment pointing to docs (cherry picked from commit e72e8f1)
McKnight-42
added a commit
that referenced
this pull request
Aug 30, 2023
) * update RELEASE_BRANCH env * remove some connection fields that may be sensitive user information that we don't want showing up in dbt debug commands * add changelog and comment pointing to docs (cherry picked from commit e72e8f1) Co-authored-by: Matthew McKnight <[email protected]>
philippe-boyd-maxa
pushed a commit
to maxa-ai/dbt-snowflake
that referenced
this pull request
Nov 27, 2023
…#756) * update RELEASE_BRANCH env * remove some connection fields that may be sensitive user information that we don't want showing up in dbt debug commands * add changelog and comment pointing to docs
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #754
docs dbt-labs/docs.getdbt.com/#
Problem
user credentials
private_keyandprivate_key_passphrasecan show up in logs due to dbt debug stdout, these creds are some may not want in logs.Solution
remove needed creds from
_connection_keysmethod in connections.py to remove them from adapter specific stdout.Checklist