Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove private_key_path from SnowflakeCredentials._connection_keys #949

Closed
2 tasks done
jtcohen6 opened this issue Mar 22, 2024 · 0 comments · Fixed by #950
Closed
2 tasks done

[Bug] Remove private_key_path from SnowflakeCredentials._connection_keys #949

jtcohen6 opened this issue Mar 22, 2024 · 0 comments · Fixed by #950
Assignees
Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch bug Something isn't working

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Mar 22, 2024

Is this a new bug in dbt-snowflake?

  • I believe this is a new bug in dbt-snowflake
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

follow-up to #906 + #756

internal Slack thread

private_key_path is included in SnowflakeCredentials._connection_keys, and therefore the Jinja {{ target }} dictionary. While this value doesn't explicitly contain sensitive information itself, I'd put it in the category of password-like fields rather than the category of fields that a user needs to access at runtime.

Expected Behavior

private_key_path is not included in _connection_keys

Steps To Reproduce

n/a

Relevant log output

No response

Environment

- dbt-core: 1.7.10
- dbt-snowflake: 1.7.2

Additional Context

internal thread

@jtcohen6 jtcohen6 added the bug Something isn't working label Mar 22, 2024
@mikealfare mikealfare added backport 1.6.latest backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants