Skip to content

Commit

Permalink
[ADAP-849] removes some user connection details from stdout (dbt-labs…
Browse files Browse the repository at this point in the history
…#756)

* update RELEASE_BRANCH env

* remove some connection fields that may be sensitive user information that we don't want showing up in dbt debug commands

* add changelog and comment pointing to docs
  • Loading branch information
McKnight-42 authored and philippe-boyd-maxa committed Nov 27, 2023
1 parent 2b1809b commit c3cb776
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20230828-143834.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: remove senesitive creds from dbt debug stdout
time: 2023-08-28T14:38:34.380646-05:00
custom:
Author: McKnight-42
Issue: "754"
4 changes: 2 additions & 2 deletions dbt/adapters/snowflake/connections.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ def type(self):
def unique_field(self):
return self.account

# the results show up in the output of dbt debug runs, for more see..
# https://docs.getdbt.com/guides/dbt-ecosystem/adapter-development/3-building-a-new-adapter#editing-the-connection-manager
def _connection_keys(self):
return (
"account",
Expand All @@ -112,9 +114,7 @@ def _connection_keys(self):
"role",
"schema",
"authenticator",
"private_key",
"private_key_path",
"private_key_passphrase",
"token",
"oauth_client_id",
"query_tag",
Expand Down

0 comments on commit c3cb776

Please sign in to comment.