-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug log when type_code
fails to convert to a data_type
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
2 tasks
mikealfare
previously approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only noticed one thing, which is aesthetic. I'm not super familiar with protobuf
, but this change looks consistent with the others.
dbeatty10
commented
Apr 12, 2024
4 tasks
mikealfare
approved these changes
Apr 12, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #134
Problem
For any given adapter, it's possible that dbt doesn't recognize a data type specified in a dbt model contract. An example is dbt-labs/dbt-postgres#54
In those cases, we want there to be a mechanism for the dbt adapter to emit a log message of what's going on.
Solution
Emit a debug-level log message any time a data type is not recognized within dbt-postgres. That way, users can at least see in the logs what is going on.
Log messages will look like the following:
An example of how to utilize this log message is within dbt-labs/dbt-postgres#39
Checklist