-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make aliasing subquery configurable for render_limited #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
colin-rogers-dbt
changed the title
Make alias configurable for render_limited
Make aliasing subquery configurable for render_limited
Apr 18, 2024
mikealfare
reviewed
Apr 19, 2024
mikealfare
previously approved these changes
Apr 19, 2024
mikealfare
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #124
Currently only a subset of adapters require adding an alias to the subquery generated by
render_limited
(i.e. when a user passes the--empty
flag). Currently if a user has already aliased a referenced model or source we duplicate the aliasing and generate invalid SQL.Unfortunately at the moment we have no way of knowing if a user has already aliased the reference so quickest mitigation is to simply not add the alias if the platform does not require it. This should allow us to fix this bug for many platforms (snowflake, bigquery) but doesn't fix this for others (postgres, mysql, oracle).
dbt-snowflake update: dbt-labs/dbt-snowflake#980
docs dbt-labs/docs.getdbt.com/#
Problem
Solution
Checklist