Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aliasing subquery configurable for render_limited #179

Merged
merged 9 commits into from
Apr 22, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Apr 18, 2024

partially addresses #124

Currently only a subset of adapters require adding an alias to the subquery generated by render_limited (i.e. when a user passes the --empty flag). Currently if a user has already aliased a referenced model or source we duplicate the aliasing and generate invalid SQL.

Unfortunately at the moment we have no way of knowing if a user has already aliased the reference so quickest mitigation is to simply not add the alias if the platform does not require it. This should allow us to fix this bug for many platforms (snowflake, bigquery) but doesn't fix this for others (postgres, mysql, oracle).

dbt-snowflake update: dbt-labs/dbt-snowflake#980

docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@colin-rogers-dbt colin-rogers-dbt changed the title Make alias configurable for render_limited Make aliasing subquery configurable for render_limited Apr 18, 2024
@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review April 18, 2024 23:00
mikealfare
mikealfare previously approved these changes Apr 19, 2024
@colin-rogers-dbt colin-rogers-dbt merged commit b61d66d into main Apr 22, 2024
13 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the makeAliasingOptional branch April 22, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants