-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/powerbi): fix subTypes and add workspace_type_filter #11523
feat(ingest/powerbi): fix subTypes and add workspace_type_filter #11523
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…ub.com/sid-acryl/datahub-fork into ing-732-powerbi-connector-improvements
metadata-ingestion/src/datahub/ingestion/source/common/subtypes.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/powerbi/config.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/powerbi/powerbi.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/src/datahub/ingestion/source/powerbi/rest_api_wrapper/data_classes.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Harshal Sheth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can address this final comment in a follow-up
@@ -21,7 +21,7 @@ | |||
| `Page` | `Chart` | | |||
|
|||
- If `Tile` is created from report then `Chart.externalUrl` is set to Report.webUrl. | |||
- The `Page` information is unavailable for PowerBI PaginatedReport. | |||
- The `Page` is unavailable for PowerBI PaginatedReport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still confusing - let's add PaginatedReport to the concept mapping table which will clean things up
also, how is Report.webUrl mapped to a chart if the report is mapped to a dashboard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tile contains visualizations that can be created using a dataset, a text box, or by pinning a report. If a report is pinned within the tile, the externalUrl
will point to that report.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
@sid-acryl tests are failing |
…ahub-project#11523) Co-authored-by: Harshal Sheth <[email protected]>
No description provided.