-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/powerbi): fix subTypes and add workspace_type_filter #11523
Merged
hsheth2
merged 27 commits into
datahub-project:master
from
sid-acryl:ing-732-powerbi-connector-improvements
Oct 11, 2024
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e3398b0
WIP
sid-acryl a9cace0
WIP
sid-acryl 63145aa
WIP
sid-acryl ced6e54
added app to dashboard/report
sid-acryl e8885fa
WIP
sid-acryl 7be6d1a
Merge branch 'master' into ing-732-powerbi-connector-improvements
sid-acryl 45f056c
app as container
sid-acryl 811dd09
workspace type filter
sid-acryl d6bd5e5
workspace-type-filter
sid-acryl b83a1e0
remove app as conatiner
sid-acryl 9dced8b
Merge branch 'master' into ing-732-powerbi-connector-improvements
sid-acryl 08843b9
fix test-cases
sid-acryl c365fad
fix test-cases
sid-acryl 19ca8be
test case for workspace_type_filter
sid-acryl 8f49219
added paginated report test case
sid-acryl 6bdd0fd
updated doc
sid-acryl eda214a
Merge branch 'master' into ing-732-powerbi-connector-improvements
sid-acryl 347a0a7
updated doc
sid-acryl 3fa0730
Merge branch 'ing-732-powerbi-connector-improvements' of https://gith…
sid-acryl 658447d
Update metadata-ingestion/src/datahub/ingestion/source/powerbi/config.py
sid-acryl 7b46a88
Merge branch 'master' into ing-732-powerbi-connector-improvements
sid-acryl f2c7d84
addressed review comments
sid-acryl 6b196fa
Merge branch 'ing-732-powerbi-connector-improvements' of https://gith…
sid-acryl 5b729ee
Merge branch 'master' into ing-732-powerbi-connector-improvements
sid-acryl 5822166
address review comment
sid-acryl 4b73ff6
Merge branch 'master' into ing-732-powerbi-connector-improvements
sid-acryl 15ac4b1
update in golden files
sid-acryl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still confusing - let's add PaginatedReport to the concept mapping table which will clean things up
also, how is Report.webUrl mapped to a chart if the report is mapped to a dashboard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tile contains visualizations that can be created using a dataset, a text box, or by pinning a report. If a report is pinned within the tile, the
externalUrl
will point to that report.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see