feat(models): support dashboards containing dashboards #11529

hsheth2 · 2024-10-04T00:43:53Z

Open questions right now

Do we want the field name to be dashboards or something more generic?
Do we want to continue using the "Contains" relationship type, or use something new e.g. "Includes" to make these easy to distinguish in the future.

Will help unblock #11523

Checklist

The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
Links to related issues (if applicable)
Tests for the changes have been added/updated (if applicable)
Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

coderabbitai · 2024-10-04T00:43:59Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

asikowitz

Would like a different relationship name to be safe, but otherwise LGTM

asikowitz · 2024-10-04T21:08:49Z

metadata-models/src/main/pegasus/com/linkedin/dashboard/DashboardInfo.pdl

+   */
+  @Relationship = {
+    "/*": {
+      "name": "Contains",


I vote on new relationship name, even something ugly like DashboardContainsDashboard. In general I think the potential downsides of shared relationship names (inability to distinguish between the two for some future use case) outweigh the benefits (shared logic)

asikowitz · 2024-10-04T21:14:44Z

metadata-models/src/main/pegasus/com/linkedin/dashboard/DashboardInfo.pdl

+      "isLineage": true
+    }
+  }
+  dashboards: array[Urn] = [ ]


Should this be a list of edges rather than list of urns, to support time-based lineage and attribution? Time-based seems unnecessary here but I could see value in attribution

Actually, I think both are unnecessary, but leaving this here for discussion

will just move to the Edge type, which should give us everything we need

Open questions right now - Do we want the field name to be `dashboards` or something more generic? - Do we want to continue using the "Contains" relationship type, or use something new e.g. "Includes" to make these easy to distinguish in the future.

hsheth2 · 2024-10-09T18:25:06Z

metadata-io tests were fixed by f09e18c

…ct#11529)

vercel bot deployed to Preview October 4, 2024 01:00 View deployment

asikowitz reviewed Oct 4, 2024

View reviewed changes

hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 8, 2024

vercel bot deployed to Preview October 8, 2024 19:19 View deployment

asikowitz approved these changes Oct 8, 2024

View reviewed changes

hsheth2 added 3 commits October 8, 2024 18:05

update models

dd0f6d5

update snapshots

2f8ce2f

hsheth2 force-pushed the dashboard-dashboards branch from 9aa8daa to 2f8ce2f Compare October 9, 2024 02:40

vercel bot deployed to Preview October 9, 2024 02:59 View deployment

hsheth2 merged commit 50929ce into master Oct 9, 2024
75 of 77 checks passed

hsheth2 deleted the dashboard-dashboards branch October 9, 2024 18:47

Masterchen09 mentioned this pull request Oct 17, 2024

feat(ui): support all entities with display names in browse paths v2 #11657

Open

5 tasks

sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024

feat(models): support dashboards containing dashboards (datahub-proje…

16efb04

…ct#11529)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(models): support dashboards containing dashboards #11529

feat(models): support dashboards containing dashboards #11529

hsheth2 commented Oct 4, 2024

coderabbitai bot commented Oct 4, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

asikowitz left a comment

asikowitz Oct 4, 2024

hsheth2 Oct 8, 2024

asikowitz Oct 4, 2024

hsheth2 Oct 8, 2024

hsheth2 commented Oct 9, 2024

feat(models): support dashboards containing dashboards #11529

feat(models): support dashboards containing dashboards #11529

Conversation

hsheth2 commented Oct 4, 2024

Checklist

coderabbitai bot commented Oct 4, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

asikowitz left a comment

Choose a reason for hiding this comment

asikowitz Oct 4, 2024

Choose a reason for hiding this comment

hsheth2 Oct 8, 2024

Choose a reason for hiding this comment

asikowitz Oct 4, 2024

Choose a reason for hiding this comment

hsheth2 Oct 8, 2024

Choose a reason for hiding this comment

hsheth2 commented Oct 9, 2024

CodeRabbit Configuration File (`.coderabbit.yaml`)