Implementing Rocket Commanding #165
Closed
+204
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 17, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bwz5
force-pushed
the
11-14-creating_rocket_telemetry_go_proxy
branch
from
d97e216 to
5288e38
Compare
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
2 times, most recently
from
3cd9183 to
d22554b
Compare
bwz5
requested review from
ZachGarcia42,
cameron-goddard,
nragland,
maxslarsson and
AlyNat75
as code owners
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (11/17/24)1 reviewer was added to this PR based on Zach Garcia's automation. |
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
3 times, most recently
from
8846d07 to
1c237c9
Compare
bwz5
force-pushed
the
11-14-creating_rocket_telemetry_go_proxy
branch
from
5288e38 to
2e0458c
Compare
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
from
1c237c9 to
38d6275
Compare
bwz5
force-pushed
the
11-14-creating_rocket_telemetry_go_proxy
branch
from
2e0458c to
d6eb215
Compare
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
3 times, most recently
from
98196d9 to
bb24fbb
Compare
ZachGarcia42
force-pushed
the
11-14-creating_rocket_telemetry_go_proxy
branch
from
d6eb215 to
148731d
Compare
ZachGarcia42
force-pushed
the
11-16-implementing_rocket_commanding
branch
from
bb24fbb to
17cc4c6
Compare
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
from
17cc4c6 to
a7e3348
Compare
fill/umbilical/proto_build.cc
Outdated
| RocketTelemetry RocketTelemetryProtoBuilder::buildProto(){ | ||
| RocketTelemetry rocketTelemetry; | ||
|
|
||
| if (!serial_data){ | ||
| if (serial_data.is_open()){ |
There was a problem hiding this comment.
We should make a ticket to attempt reconnection if the connection fails
bwz5
force-pushed
the
11-14-creating_rocket_telemetry_go_proxy
branch
from
148731d to
848ebc6
Compare
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
from
a7e3348 to
4739290
Compare
bwz5
force-pushed
the
11-14-creating_rocket_telemetry_go_proxy
branch
from
848ebc6 to
083456d
Compare
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
5 times, most recently
from
43a09a6 to
6f59b5d
Compare
bwz5
force-pushed
the
11-14-creating_rocket_telemetry_go_proxy
branch
from
083456d to
4547825
Compare
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
9 times, most recently
from
38ba2e9 to
0c6c2fc
Compare
bwz5
force-pushed
the
11-14-creating_rocket_telemetry_go_proxy
branch
from
4547825 to
07133ea
Compare
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
2 times, most recently
from
789fb43 to
5e3cf1f
Compare
bwz5
force-pushed
the
11-14-creating_rocket_telemetry_go_proxy
branch
from
07133ea to
c537334
Compare
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
6 times, most recently
from
98b98de to
4ae3e2b
Compare
bwz5
force-pushed
the
11-14-creating_rocket_telemetry_go_proxy
branch
from
c537334 to
276c650
Compare
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
from
4ae3e2b to
01a9b5c
Compare
bwz5
force-pushed
the
11-16-implementing_rocket_commanding
branch
from
01a9b5c to
d6b0f88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.