Implementing Rocket Umbilical #144
Open
+214
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bwz5
force-pushed
the
11-07-implementing_rocket_telemetry
branch
7 times, most recently
from
b81bbf2 to
e90a93f
Compare
bwz5
requested review from
ZachGarcia42,
cameron-goddard,
nragland,
maxslarsson and
AlyNat75
as code owners
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (11/13/24)1 reviewer was added to this PR based on Zach Garcia's automation. |
| @@ -45,7 +45,12 @@ message Command { | |||
| message CommandReply {} | |||
|
|
|||
| // The telemetry request message | |||
| message TelemetryRequest {} | |||
| message FillStationTelemetryRequest {} | |||
There was a problem hiding this comment.
You'll have to update the Go proxy's Request to use this new name
ZachGarcia42
requested changes
Nov 14, 2024
bwz5
force-pushed
the
11-07-implementing_rocket_telemetry
branch
2 times, most recently
from
410116f to
54e1f8d
Compare
bwz5
force-pushed
the
11-07-implementing_rocket_telemetry
branch
from
54e1f8d to
65cdc0c
Compare
bwz5
force-pushed
the
11-07-implementing_rocket_telemetry
branch
3 times, most recently
from
594b664 to
dc3af88
Compare
bwz5
force-pushed
the
11-07-implementing_rocket_telemetry
branch
from
dc3af88 to
50a2700
Compare
bwz5
force-pushed
the
11-07-implementing_rocket_telemetry
branch
from
50a2700 to
84259a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.