Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Rocket Telemetry Go Proxy #160

Open
wants to merge 1 commit into
base: 11-07-implementing_rocket_telemetry
Choose a base branch
from

Conversation

bwz5
Copy link
Contributor

@bwz5 bwz5 commented Nov 14, 2024

No description provided.

Copy link
Contributor Author

bwz5 commented Nov 14, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bwz5 bwz5 marked this pull request as ready for review November 14, 2024 22:02
Copy link

graphite-app bot commented Nov 14, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (11/14/24)

1 reviewer was added to this PR based on Zach Garcia's automation.

Copy link
Contributor

@ZachGarcia42 ZachGarcia42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the code. We also need to fix the CI builds on Github (and add new ones for the new proxy)

go-proxies/pkg/types/types.go Outdated Show resolved Hide resolved
@bwz5 bwz5 force-pushed the 11-14-creating_rocket_telemetry_go_proxy branch 4 times, most recently from a75e61f to 8b1678b Compare November 15, 2024 21:24
@bwz5 bwz5 force-pushed the 11-07-implementing_rocket_telemetry branch from 54e1f8d to 65cdc0c Compare November 17, 2024 02:42
@bwz5 bwz5 force-pushed the 11-14-creating_rocket_telemetry_go_proxy branch from 8b1678b to d97e216 Compare November 17, 2024 02:42
@bwz5 bwz5 force-pushed the 11-07-implementing_rocket_telemetry branch from 65cdc0c to 692ad3e Compare November 17, 2024 17:57
@bwz5 bwz5 force-pushed the 11-14-creating_rocket_telemetry_go_proxy branch from d97e216 to 5288e38 Compare November 17, 2024 17:58
@bwz5 bwz5 force-pushed the 11-07-implementing_rocket_telemetry branch from 692ad3e to 594b664 Compare November 17, 2024 22:39
@bwz5 bwz5 force-pushed the 11-14-creating_rocket_telemetry_go_proxy branch from 5288e38 to 2e0458c Compare November 17, 2024 22:39
@bwz5 bwz5 force-pushed the 11-07-implementing_rocket_telemetry branch from 594b664 to dc3af88 Compare November 17, 2024 22:46
@bwz5 bwz5 force-pushed the 11-14-creating_rocket_telemetry_go_proxy branch from 2e0458c to d6eb215 Compare November 17, 2024 22:46
@ZachGarcia42 ZachGarcia42 force-pushed the 11-14-creating_rocket_telemetry_go_proxy branch from d6eb215 to 148731d Compare November 18, 2024 20:18
Copy link
Contributor

@ZachGarcia42 ZachGarcia42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Thanks for all your hard work on this recently!

@bwz5 bwz5 force-pushed the 11-07-implementing_rocket_telemetry branch from dc3af88 to 50a2700 Compare November 22, 2024 19:25
@bwz5 bwz5 force-pushed the 11-14-creating_rocket_telemetry_go_proxy branch from 148731d to 848ebc6 Compare November 22, 2024 19:25
@bwz5 bwz5 force-pushed the 11-07-implementing_rocket_telemetry branch from 50a2700 to 84259a4 Compare December 6, 2024 21:29
@bwz5 bwz5 force-pushed the 11-14-creating_rocket_telemetry_go_proxy branch from 848ebc6 to 083456d Compare December 6, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants