Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings #272

Merged
merged 8 commits into from
Feb 25, 2025
Merged

Fix clippy warnings #272

merged 8 commits into from
Feb 25, 2025

Conversation

tylerfanelli
Copy link
Member

@tylerfanelli tylerfanelli commented Feb 25, 2025 •
edited
Loading

Fair amount of clippy fixes spanning multiple files.

@tylerfanelli tylerfanelli mentioned this pull request Feb 25, 2025
Merged
@tylerfanelli tylerfanelli changed the title rutabaga_gfx: Fix clippy warnings Fix clippy warnings Feb 25, 2025
@tylerfanelli tylerfanelli force-pushed the clippy branch 2 times, most recently from 8a681a2 to e4e2bd5 Compare February 25, 2025 00:53
jakecorrenti
jakecorrenti approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@jakecorrenti jakecorrenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mtjhrc
mtjhrc requested changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@mtjhrc mtjhrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, though I am not sure if I am personally a fan of this clippy warning with all of the ( ). I am not gonna fight it though, we should probably use the recommendation by clippy.

Please take another look at the map_or -> is_none_or suggestion, I think we can use it.

@tylerfanelli
Copy link
Member Author

PR looks good, though I am not sure if I am personally a fan of this clippy warning with all of the ( ). I am not gonna fight it though, we should probably use the recommendation by clippy.

Personally I'm not a fan either, but also don't like to fight clippy. Perhaps we can relax clippy's rules a bit? Up to you.

Please take another look at the map_or -> is_none_or suggestion, I think we can use it.

It's currently an unstable library feature (I believe), which was preventing me from using that.

@mtjhrc
Copy link
Collaborator

mtjhrc commented Feb 25, 2025 •
edited
Loading

Please take another look at the map_or -> is_none_or suggestion, I think we can use it.

It's currently an unstable library feature (I believe), which was preventing me from using that.

What version of rust are you using though? As of Rust 1.82 (released 17 October 2024) it should be stable. So I don't think it's unreasonable to use it, though still relatively new.

@tylerfanelli
Copy link
Member Author

Yep, I was on an older version. Fixing now.

@tylerfanelli
Copy link
Member Author

@mtjhrc Can you re-review?

mtjhrc
mtjhrc approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@mtjhrc mtjhrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@tylerfanelli tylerfanelli merged commit 890bf8f into containers:main Feb 25, 2025
5 checks passed
@tylerfanelli tylerfanelli deleted the clippy branch February 27, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtjhrc mtjhrc mtjhrc approved these changes

@jakecorrenti jakecorrenti jakecorrenti approved these changes

@MatiasVara MatiasVara Awaiting requested review from MatiasVara MatiasVara is a code owner

@slp slp Awaiting requested review from slp slp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerfanelli @mtjhrc @jakecorrenti