tee: Remove legacy AMD-SEV module #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerfanelli
requested review from
MatiasVara,
mtjhrc and
slp
as code owners
|
The clippy warnings are handled by #272. Once that is merged, this can be rebased. |
To prepare for the updating of the Rust SEV library to 5.0.0, remove the legacy SEV/SEV-ES module. AMD has all but deprecated legacy SEV, and has instead opted to push all new development to SEV-SNP. As such, the SEV library is intending to deprecate legacy SEV. Signed-off-by: Tyler Fanelli <[email protected]>
tylerfanelli
force-pushed
the
sev-remove
branch
from
bf6f9b6 to
8e8df98
Compare
Comment on lines
-472
to
+442
| sev: Option<AmdSev>, | ||
| tee: Option<AmdSnp>, |
There was a problem hiding this comment.
Not blocking, but I'm wondering if this should be named snp: ...? It's going to get re-named once TDX and CCA land anyways
That is all SEV-SNP specific. |
|
It's kind of sad to see this go, but I guess it's for the better. |
slp
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare for the updating of the Rust SEV library to 5.0.0, remove the legacy SEV/SEV-ES module. AMD has all but deprecated legacy SEV, and has instead opted to push all new development to SEV-SNP.
As such, the SEV library is intending to deprecate legacy SEV.