tsconfig.json: don't typecheck esbuild plugins #20730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our TypeScript config is setup to check our code that will be bundled and run in the browser. It shouldn't be running on esbuild plugins that are run inside of node, and we never intended for it to. Unfortunately, we mix our esbuild plugins into pkg/lib/ alongside browser-based code, so it gets lumped in. Add some excludes. Fortunately, we don't have to copy this to other projects (like Cockpit Files) because they only check `src/*` in the first place (and only include files in other directories if they are explicitly imported).
allisonkarlitskaya
added
the
no-test
martinpitt
reviewed
Jul 9, 2024
martinpitt
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our TypeScript config is setup to check our code that will be bundled and run in the browser. It shouldn't be running on esbuild plugins that are run inside of node, and we never intended for it to. Unfortunately, we mix our esbuild plugins into pkg/lib/ alongside browser-based code, so it gets lumped in.
Add some excludes. Fortunately, we don't have to copy this to other projects (like Cockpit Files) because they only check
src/*in the first place (and only include files in other directories if they are explicitly imported).