Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig.json: don't typecheck esbuild plugins #20730

Merged

Commits on Jul 9, 2024

  1. tsconfig.json: don't typecheck esbuild plugins

    Our TypeScript config is setup to check our code that will be bundled
    and run in the browser.  It shouldn't be running on esbuild plugins
    that are run inside of node, and we never intended for it to.
    Unfortunately, we mix our esbuild plugins into pkg/lib/ alongside
    browser-based code, so it gets lumped in.
    
    Add some excludes.  Fortunately, we don't have to copy this to other
    projects (like Cockpit Files) because they only check `src/*` in the
    first place (and only include files in other directories if they are
    explicitly imported).
    allisonkarlitskaya committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    4c4f2f7 View commit details
    Browse the repository at this point in the history