Skip to content

Commit

Permalink
tsconfig.json: don't typecheck esbuild plugins
Browse files Browse the repository at this point in the history
Our TypeScript config is setup to check our code that will be bundled
and run in the browser.  It shouldn't be running on esbuild plugins
that are run inside of node, and we never intended for it to.
Unfortunately, we mix our esbuild plugins into pkg/lib/ alongside
browser-based code, so it gets lumped in.

Add some excludes.  Fortunately, we don't have to copy this to other
projects (like Cockpit Files) because they only check `src/*` in the
first place (and only include files in other directories if they are
explicitly imported).
  • Loading branch information
allisonkarlitskaya authored and martinpitt committed Jul 9, 2024
1 parent d1a5fd0 commit ff8db05
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,10 @@
"include": [
"pkg/**/*"
],
"exclude": [
// these are part of the build system, not the app
"pkg/lib/esbuild-*.js",
"pkg/lib/cockpit-*-plugin.js",
"pkg/lib/*2po.js"
],
}

0 comments on commit ff8db05

Please sign in to comment.