Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync requirements.txt for all images and update Postgres versions to latest minors to fix builds #155

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

onurctirtir
Copy link
Member

@onurctirtir onurctirtir commented Feb 16, 2024

Bake new images for citusdata/citus#7491.

We also update Postgres minor versions to resolve build issues that happens due to some portion of images assuming that we're always using latest minors --regardless of what circleci/images/PG_VERSIONS says, see https://github.com/citusdata/the-process/actions/runs/7928205849/job/21646015823#step:4:1061.

@onurctirtir onurctirtir changed the title Sync requirements.txt for all images Sync requirements.txt for all images and update pg versions to fix builds Feb 16, 2024
@onurctirtir onurctirtir changed the title Sync requirements.txt for all images and update pg versions to fix builds Sync requirements.txt for all images and update Postgres versions to latest minors to fix builds Feb 16, 2024
@onurctirtir onurctirtir merged commit 390dab3 into master Feb 16, 2024
15 checks passed
@onurctirtir onurctirtir deleted the update-requirements-txt-files branch February 16, 2024 13:57
onurctirtir added a commit to citusdata/citus that referenced this pull request Feb 16, 2024
…rsions to latest minors (#7491)

Let's use version 2.3.7 to fix the following error as we do in docker
images created in https://github.com/citusdata/the-process/ repo.
```
ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/home/onurctirtir/.local/share/virtualenvs/regress-ffZKpSmO/lib/python3.9/site-packages/werkzeug/urls.py)
```

And changing werkzeug version required rebuilding Pipfile.lock file in
src/test/regress. Before updating this Pipfile.lock file, we want to
make sure that versions specified there don't break any tests. And to
ensure that this is the case,
citusdata/the-process#155 synchronizes
requirements.txt file based on new Pipfile.lock and hence this PR
updates test image suffix accordingly.

Also, while updating citusdata/the-process#155,
I also had to update Postgres versions to latest minors to make image
builds passing again and updating Postgres versions in images requires
updating Postgres versions in this repo too. While doing that, we also
update Postgres version used in devcontainer too.
paragikjain pushed a commit to paragikjain/citus that referenced this pull request Jun 17, 2024
…rsions to latest minors (citusdata#7491)

Let's use version 2.3.7 to fix the following error as we do in docker
images created in https://github.com/citusdata/the-process/ repo.
```
ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/home/onurctirtir/.local/share/virtualenvs/regress-ffZKpSmO/lib/python3.9/site-packages/werkzeug/urls.py)
```

And changing werkzeug version required rebuilding Pipfile.lock file in
src/test/regress. Before updating this Pipfile.lock file, we want to
make sure that versions specified there don't break any tests. And to
ensure that this is the case,
citusdata/the-process#155 synchronizes
requirements.txt file based on new Pipfile.lock and hence this PR
updates test image suffix accordingly.

Also, while updating citusdata/the-process#155,
I also had to update Postgres versions to latest minors to make image
builds passing again and updating Postgres versions in images requires
updating Postgres versions in this repo too. While doing that, we also
update Postgres version used in devcontainer too.

(cherry picked from commit 74b55d0)
paragikjain pushed a commit to paragikjain/citus that referenced this pull request Jun 17, 2024
…rsions to latest minors (citusdata#7491)

Let's use version 2.3.7 to fix the following error as we do in docker
images created in https://github.com/citusdata/the-process/ repo.
```
ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/home/onurctirtir/.local/share/virtualenvs/regress-ffZKpSmO/lib/python3.9/site-packages/werkzeug/urls.py)
```

And changing werkzeug version required rebuilding Pipfile.lock file in
src/test/regress. Before updating this Pipfile.lock file, we want to
make sure that versions specified there don't break any tests. And to
ensure that this is the case,
citusdata/the-process#155 synchronizes
requirements.txt file based on new Pipfile.lock and hence this PR
updates test image suffix accordingly.

Also, while updating citusdata/the-process#155,
I also had to update Postgres versions to latest minors to make image
builds passing again and updating Postgres versions in images requires
updating Postgres versions in this repo too. While doing that, we also
update Postgres version used in devcontainer too.

(cherry picked from commit 74b55d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants