Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce using werkzeug 2.3.7 for failure tests and update Postgres versions to latest minors #7491

Merged
merged 9 commits into from
Feb 16, 2024

Conversation

onurctirtir
Copy link
Member

@onurctirtir onurctirtir commented Feb 9, 2024

Let's use version 2.3.7 to fix the following error as we do in docker images created in https://github.com/citusdata/the-process/ repo.

ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/home/onurctirtir/.local/share/virtualenvs/regress-ffZKpSmO/lib/python3.9/site-packages/werkzeug/urls.py)

And changing werkzeug version required rebuilding Pipfile.lock file in src/test/regress. Before updating this Pipfile.lock file, we want to make sure that versions specified there don't break any tests. And to ensure that this is the case, citusdata/the-process#155 synchronizes requirements.txt file based on new Pipfile.lock and hence this PR updates test image suffix accordingly.

Also, while updating citusdata/the-process#155, I also had to update Postgres versions to latest minors to make image builds passing again and updating Postgres versions in images requires updating Postgres versions in this repo too. While doing that, we also update Postgres version used in devcontainer too.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Merging #7491 (ba60957) into main (15a3ade) will decrease coverage by 0.78%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7491      +/-   ##
==========================================
- Coverage   89.60%   88.83%   -0.78%     
==========================================
  Files         282      282              
  Lines       60322    60321       -1     
  Branches     7512     7510       -2     
==========================================
- Hits        54052    53586     -466     
- Misses       4116     4553     +437     
- Partials     2154     2182      +28     

@JelteF
Copy link
Contributor

JelteF commented Feb 14, 2024

ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/home/onurctirtir/.local/share/virtualenvs/regress-ffZKpSmO/lib/python3.9/site-packages/werkzeug/urls.py)

Is this error actually causing problems (e.g. failing tests)? Or is it simply some annoying output that is being displayed? I think to limit the amount of security warnings we get it would be nice not to pin libraries to some old version if not strictly needed.

@onurctirtir
Copy link
Member Author

ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/home/onurctirtir/.local/share/virtualenvs/regress-ffZKpSmO/lib/python3.9/site-packages/werkzeug/urls.py)

Is this error actually causing problems (e.g. failing tests)? Or is it simply some annoying output that is being displayed? I think to limit the amount of security warnings we get it would be nice not to pin libraries to some old version if not strictly needed.

The error causes regression test suit to fail indeed.

@JelteF
Copy link
Contributor

JelteF commented Feb 14, 2024

Hmm okay, it seems Pipfile.lock got outdated with our the-process images then. Because Pipfile.lock is already listing 3.0.2 for werkzeug while failtester its requirements.txt has 2.3.7: https://github.com/citusdata/the-process/blob/master/circleci/images/failtester/files/etc/requirements.txt#L54

I think going for 2.3.7 makes more sense then. Also there should be a matching PR to update the images in the-process and this PR should start using those images to check that everything works fine.

@onurctirtir onurctirtir changed the title Enforce using werkzeug 2.2.2 for failure tests Enforce using werkzeug 2.3.7 for failure tests Feb 16, 2024
@onurctirtir onurctirtir changed the title Enforce using werkzeug 2.3.7 for failure tests Enforce using werkzeug 2.3.7 for failure tests and update Postgres versions to latest minors Feb 16, 2024
onurctirtir added a commit to citusdata/the-process that referenced this pull request Feb 16, 2024
…latest minors to fix builds (#155)

Bake new images for citusdata/citus#7491.

We also update Postgres minor versions to resolve build issues that
happens due to some portion of images assuming that we're always using
latest minors --regardless of what circleci/images/PG_VERSIONS says, see
https://github.com/citusdata/the-process/actions/runs/7928205849/job/21646015823#step:4:1061.
pg15_version: '{ "major": "15", "full": "15.5" }'
pg16_version: '{ "major": "16", "full": "16.1" }'
upgrade_pg_versions: "14.10-15.5-16.1"
image_suffix: "-dev-4f49b4a"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder that this needs to be replaced with a non-dev image before merging once citusdata/the-process#155 has passed through CI

@onurctirtir onurctirtir enabled auto-merge (squash) February 16, 2024 14:37
@onurctirtir onurctirtir merged commit 74b55d0 into main Feb 16, 2024
126 checks passed
@onurctirtir onurctirtir deleted the fix-pipfile-regress branch February 16, 2024 14:38
paragikjain pushed a commit to paragikjain/citus that referenced this pull request Jun 17, 2024
…rsions to latest minors (citusdata#7491)

Let's use version 2.3.7 to fix the following error as we do in docker
images created in https://github.com/citusdata/the-process/ repo.
```
ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/home/onurctirtir/.local/share/virtualenvs/regress-ffZKpSmO/lib/python3.9/site-packages/werkzeug/urls.py)
```

And changing werkzeug version required rebuilding Pipfile.lock file in
src/test/regress. Before updating this Pipfile.lock file, we want to
make sure that versions specified there don't break any tests. And to
ensure that this is the case,
citusdata/the-process#155 synchronizes
requirements.txt file based on new Pipfile.lock and hence this PR
updates test image suffix accordingly.

Also, while updating citusdata/the-process#155,
I also had to update Postgres versions to latest minors to make image
builds passing again and updating Postgres versions in images requires
updating Postgres versions in this repo too. While doing that, we also
update Postgres version used in devcontainer too.

(cherry picked from commit 74b55d0)
paragikjain pushed a commit to paragikjain/citus that referenced this pull request Jun 17, 2024
…rsions to latest minors (citusdata#7491)

Let's use version 2.3.7 to fix the following error as we do in docker
images created in https://github.com/citusdata/the-process/ repo.
```
ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/home/onurctirtir/.local/share/virtualenvs/regress-ffZKpSmO/lib/python3.9/site-packages/werkzeug/urls.py)
```

And changing werkzeug version required rebuilding Pipfile.lock file in
src/test/regress. Before updating this Pipfile.lock file, we want to
make sure that versions specified there don't break any tests. And to
ensure that this is the case,
citusdata/the-process#155 synchronizes
requirements.txt file based on new Pipfile.lock and hence this PR
updates test image suffix accordingly.

Also, while updating citusdata/the-process#155,
I also had to update Postgres versions to latest minors to make image
builds passing again and updating Postgres versions in images requires
updating Postgres versions in this repo too. While doing that, we also
update Postgres version used in devcontainer too.

(cherry picked from commit 74b55d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants