Update import paths of google genai modules to fix pyright errors #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosukehigashi
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Code changes LGTM! It looks like the pytest job has been stuck for a while now https://github.com/citadel-ai/langcheck/actions/runs/13171614215/job/36762893285?pr=174 🤔
|
Turned out we needed to change some settings! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by #173 (comment), current
src/langcheck/metrics/eval_clients/_gemini.pydoes not passpyrightchecks with the latestgoogle-generativeai==0.8.4.This is because
py.typedis added to the library form this version. Nothing has changed behavior-wise.Ref: google-gemini/generative-ai-python#509
Updated the import paths and confirmed that the behavior of
GeminiEvalCilentdoes not change with bothgoogle-generativeai==0.8.3andgoogle-generativeai==0.8.4.