-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Langcheck __version__ #173
Conversation
By the way, the current head (v0.9.0) is failing the pyright test mentioned in the contribution guide, due to a problem in metrics/eval_clients/_gemini.py |
Thanks for your contribution, @matchcase!! The change LGTM, could you also add changes to this section so that we don't forget to update the version string? Also thanks for reporting the type error, seemingly it is because the interface exposed to the type checkers changed in the latest I'll approve the PR and merge it into main once the doc is updated and the type error is resolved with #174 !! |
Hi @liwii, |
Thanks a lot, looks perfect!! We're differently welcome for more contributions!! Is it okay for us to look around the issues and get back to you in a few days? (There are also some undocumented ones I think) |
Sure, that works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Thanks a lot for the contribution!!
See Issue #74