Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Langcheck __version__ #173

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Added Langcheck __version__ #173

merged 3 commits into from
Feb 7, 2025

Conversation

matchcase
Copy link
Contributor

See Issue #74

@matchcase
Copy link
Contributor Author

By the way, the current head (v0.9.0) is failing the pyright test mentioned in the contribution guide, due to a problem in metrics/eval_clients/_gemini.py
I think it might also make sense to pin the Python version for this repository, as some of the dependencies do not work with the latest Python version.

@liwii
Copy link
Contributor

liwii commented Feb 6, 2025

Thanks for your contribution, @matchcase!!

The change LGTM, could you also add changes to this section so that we don't forget to update the version string?

Also thanks for reporting the type error, seemingly it is because the interface exposed to the type checkers changed in the latest google-generativeai library. Code behavior didn't change, so I think no need of making a new patch release, but separately working on that in #174 .

I'll approve the PR and merge it into main once the doc is updated and the type error is resolved with #174 !!

@matchcase
Copy link
Contributor Author

Hi @liwii,
Awesome, I've added the step in contributing.md!
I was wondering if there are any other issues (perhaps more challenging ones) that I could try working on?

@liwii
Copy link
Contributor

liwii commented Feb 6, 2025

Thanks a lot, looks perfect!!

We're differently welcome for more contributions!! Is it okay for us to look around the issues and get back to you in a few days? (There are also some undocumented ones I think)

@matchcase
Copy link
Contributor Author

Sure, that works!

Copy link
Contributor

@liwii liwii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks a lot for the contribution!!

@liwii
Copy link
Contributor

liwii commented Feb 7, 2025

As for the new project, I mentioned you in #175 and #176, so let's discuss there!!

@liwii liwii merged commit 20037a6 into citadel-ai:main Feb 7, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants